test: used fixturesDir from fixtures modules #16813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkogovsek - looks like you pushed changed without: on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again? |
gireeshpunathil
added
the
code-and-learn
gireeshpunathil
approved these changes
Nov 6, 2017
|
@kkogovsek See also the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment |
kkogovsek
force-pushed
the
master
branch
2 times, most recently
from
774834b
to
a340fd4
Compare
Trott
approved these changes
Nov 7, 2017
|
Linter stalled in CI which was odd but undoubtedly unrelated to this change. Re-running linter: https://ci.nodejs.org/job/node-test-linter/13348/ |
In test-fs-realpath-on-substed-drive: Require common/fixtures module and swapped the location of fixturesDir from common to fixtures module.
|
There was a lint error, so I fixed it up (added a semi-colon). Hope that's OK! Need to re-run CI, but I'm having issues with CI right now.... |
jasnell
approved these changes
Nov 8, 2017
|
old CI is 404 now, new CI: https://ci.nodejs.org/job/node-test-pull-request/11388/ |
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 13, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures module and swapped the location of fixturesDir from common to fixtures module. PR-URL: #16813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
Landed in 1601a3c , thanks for the contribution! |
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures module and swapped the location of fixturesDir from common to fixtures module. PR-URL: #16813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures module and swapped the location of fixturesDir from common to fixtures module. PR-URL: #16813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures module and swapped the location of fixturesDir from common to fixtures module. PR-URL: #16813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures module and swapped the location of fixturesDir from common to fixtures module. PR-URL: #16813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures module and swapped the location of fixturesDir from common to fixtures module. PR-URL: #16813 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I required common/fixtures module and swapped the location of fixturesDir
from common to fixtures module.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test