From b9b278b0db6ad986b5b8f136b83414dece4ee524 Mon Sep 17 00:00:00 2001 From: jBarz Date: Tue, 17 Oct 2017 20:01:31 -0400 Subject: [PATCH 1/2] aix,test: skip test due to file size limit The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. --- test/sequential/test-fs-readfile-tostring-fail.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/sequential/test-fs-readfile-tostring-fail.js b/test/sequential/test-fs-readfile-tostring-fail.js index 2eb6ce0732dd70..3f755cadae0690 100644 --- a/test/sequential/test-fs-readfile-tostring-fail.js +++ b/test/sequential/test-fs-readfile-tostring-fail.js @@ -8,7 +8,10 @@ if (!common.enoughTestMem) const assert = require('assert'); const fs = require('fs'); const path = require('path'); +const cp = require('child_process'); const kStringMaxLength = process.binding('buffer').kStringMaxLength; +if (common.isAIX && Number(cp.execSync('ulimit -f')) < kStringMaxLength) + common.skip('intensive toString tests due to file size confinements'); common.refreshTmpDir(); From 4accbed0e1c372d902cda3568bc0d93a6e9ba54d Mon Sep 17 00:00:00 2001 From: jBarz Date: Wed, 18 Oct 2017 10:20:44 -0400 Subject: [PATCH 2/2] multiply by block size --- test/sequential/test-fs-readfile-tostring-fail.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/sequential/test-fs-readfile-tostring-fail.js b/test/sequential/test-fs-readfile-tostring-fail.js index 3f755cadae0690..4f0ae7eb1e192a 100644 --- a/test/sequential/test-fs-readfile-tostring-fail.js +++ b/test/sequential/test-fs-readfile-tostring-fail.js @@ -10,7 +10,7 @@ const fs = require('fs'); const path = require('path'); const cp = require('child_process'); const kStringMaxLength = process.binding('buffer').kStringMaxLength; -if (common.isAIX && Number(cp.execSync('ulimit -f')) < kStringMaxLength) +if (common.isAIX && (Number(cp.execSync('ulimit -f')) * 512) < kStringMaxLength) common.skip('intensive toString tests due to file size confinements'); common.refreshTmpDir();