test: http2 connectionListener reject client #16080
Conversation
trivikr
force-pushed
the
test-http2-https-fallback
branch
from
6e56361 to
54b77aa
Compare
|
|
||
| server.listen(0); | ||
|
|
||
| // Test for checking undefined timeout (code: https://git.io/vdzE9) | ||
| server.setTimeout(undefined); |
There was a problem hiding this comment.
This feels out of place in this test. I would suggest removing it. If it needs to be tested, there must be a more appropriate existing test to insert it in (one that already deals with timeouts). (The link to git.io is also unnecessary.)
There was a problem hiding this comment.
Removing the test or removing the check for this.timeout in connectionListener?
I think latter should be done as timeout is always expected to be a number (either default one or the one explicitly set).
There was a problem hiding this comment.
Removing the test for setTimeout(undefined). It doesn't relate to http2 https fallback and is likely to just confuse people in the future.
There was a problem hiding this comment.
Removed the test for setTimeout(undefined) and updated the commit
This code change modifies connectionListener tests to cover test case
where this.emit('unknownProtocol', socket) returns false
Refs: nodejs#14985
trivikr
force-pushed
the
test-http2-https-fallback
branch
from
54b77aa to
b56b64a
Compare
|
Can someone create CI link for this request? |
This code change modifies connectionListener tests to cover test case
where this.emit('unknownProtocol', socket) returns false
PR-URL: #16080
Ref: #14985
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
|
Landed in 3cc725d |
This code change modifies connectionListener tests to cover test case
where this.emit('unknownProtocol', socket) returns false
PR-URL: #16080
Ref: #14985
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This code change modifies connectionListener tests to cover test case
where this.emit('unknownProtocol', socket) returns false
PR-URL: nodejs/node#16080
Ref: nodejs/node#14985
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This code change modifies connectionListener tests to cover a test case where
this.emit('unknownProtocol', socket)returns falsenode/lib/internal/http2/core.js
Lines 2284 to 2287 in e012229
Refs: #14985
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, http2