Replaced fixturesDir with common.fixtures module #16051
Conversation
|
Ah, pressed the approval button too early, the commit message is missing subsytem labels. I guess whoever lands this can change the commit message to something like |
Trott
added
the
code-and-learn
|
Welcome to the dark side @rachelnicole 😉. Hope C&L was fun. Besides the commit message there's also a list error: This can also be fixed by whomever lands this. |
|
@refack I can totally remove the reference to |
Follow up by the OP is always appreciated, thank you. 🥇 |
|
P.S. you can also locally run |
|
@refack i'm on windows and neither of those things worked. D: i might be missing some stuff |
|
Ohh yeah us Windows devs need to do things a little different ( |
|
Last CI before landing: https://ci.nodejs.org/job/node-test-pull-request/10476/ |
|
Landed in bdf711d, thanks for the contribution! |
PR-URL: #16051 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #16051 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: nodejs/node#16051 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #16051 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #16051 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #16051 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test