From 18feb2fa567e741b1e36a743beb64779381f07d9 Mon Sep 17 00:00:00 2001 From: Oscar Funes Date: Fri, 6 Oct 2017 10:25:26 -0700 Subject: [PATCH 1/3] test: fix typo --- test/parallel/test-child-process-silent.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/parallel/test-child-process-silent.js b/test/parallel/test-child-process-silent.js index b280e101810c54..7edc9d232fba65 100644 --- a/test/parallel/test-child-process-silent.js +++ b/test/parallel/test-child-process-silent.js @@ -74,17 +74,17 @@ if (process.argv[2] === 'pipe') { child.stdout.pipe(process.stdout, { end: false }); let childSending = false; - let childReciveing = false; + let childReceiving = false; child.on('message', function(message) { if (childSending === false) { childSending = (message === 'message from child'); } - if (childReciveing === false) { - childReciveing = (message === 'got message from master'); + if (childReceiving === false) { + childReceiving = (message === 'got message from master'); } - if (childReciveing === true) { + if (childReceiving === true) { child.kill(); } }); @@ -102,6 +102,6 @@ if (process.argv[2] === 'pipe') { // Check message system assert.ok(childSending, 'The child was able to send a message'); - assert.ok(childReciveing, 'The child was able to receive a message'); + assert.ok(childReceiving, 'The child was able to receive a message'); }); } From 4e72bec42cc3df8732ed51b9408db59d44afcd85 Mon Sep 17 00:00:00 2001 From: Oscar Funes Date: Fri, 6 Oct 2017 10:25:41 -0700 Subject: [PATCH 2/3] test: fix stderr reference --- test/parallel/test-child-process-silent.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-child-process-silent.js b/test/parallel/test-child-process-silent.js index 7edc9d232fba65..7cd12a0a7a20e9 100644 --- a/test/parallel/test-child-process-silent.js +++ b/test/parallel/test-child-process-silent.js @@ -62,7 +62,7 @@ if (process.argv[2] === 'pipe') { stdoutData = true; }); let stderrData = false; - parent.stdout.on('data', function() { + parent.stderr.on('data', function() { stderrData = true; }); From dda7831aac63252f1ae829cef736b3d0a1ab41e7 Mon Sep 17 00:00:00 2001 From: Oscar Funes Date: Fri, 6 Oct 2017 10:27:42 -0700 Subject: [PATCH 3/3] test: remove literal messages to only use assert default message --- test/parallel/test-child-process-silent.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-child-process-silent.js b/test/parallel/test-child-process-silent.js index 7cd12a0a7a20e9..20ad9683dfa622 100644 --- a/test/parallel/test-child-process-silent.js +++ b/test/parallel/test-child-process-silent.js @@ -97,11 +97,11 @@ if (process.argv[2] === 'pipe') { parent.kill(); // Check std(out|err) pipes - assert.ok(!stdoutData, 'The stdout socket was piped to parent'); - assert.ok(!stderrData, 'The stderr socket was piped to parent'); + assert.ok(!stdoutData); + assert.ok(!stderrData); // Check message system - assert.ok(childSending, 'The child was able to send a message'); - assert.ok(childReceiving, 'The child was able to receive a message'); + assert.ok(childSending); + assert.ok(childReceiving); }); }