From 7aaf31a8e8596382e6790bbd5a9cb0fd38c4a942 Mon Sep 17 00:00:00 2001 From: AlexeyM Date: Fri, 6 Oct 2017 09:40:49 -0700 Subject: [PATCH 1/3] test: replace common.fixturesDir with usage of common.fixtures --- test/parallel/test-fs-symlink-dir-junction.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-fs-symlink-dir-junction.js b/test/parallel/test-fs-symlink-dir-junction.js index bc7495aed32569..0dcaaba3f37c9d 100644 --- a/test/parallel/test-fs-symlink-dir-junction.js +++ b/test/parallel/test-fs-symlink-dir-junction.js @@ -21,12 +21,13 @@ 'use strict'; const common = require('../common'); +const fixtures = require('../common/fixtures'); const assert = require('assert'); const path = require('path'); const fs = require('fs'); // test creating and reading symbolic link -const linkData = path.join(common.fixturesDir, 'cycles/'); +const linkData = path.join(fixtures.fixturesDir, 'cycles/'); const linkPath = path.join(common.tmpDir, 'cycles_link'); common.refreshTmpDir(); From b5aeda0a66875040313f4197c93cc856b9a0b992 Mon Sep 17 00:00:00 2001 From: AlexeyM Date: Fri, 6 Oct 2017 09:46:01 -0700 Subject: [PATCH 2/3] test: remove console.log --- test/parallel/test-fs-symlink-dir-junction.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/parallel/test-fs-symlink-dir-junction.js b/test/parallel/test-fs-symlink-dir-junction.js index 0dcaaba3f37c9d..12a1c6b5c7935e 100644 --- a/test/parallel/test-fs-symlink-dir-junction.js +++ b/test/parallel/test-fs-symlink-dir-junction.js @@ -32,9 +32,6 @@ const linkPath = path.join(common.tmpDir, 'cycles_link'); common.refreshTmpDir(); -console.log(`linkData: ${linkData}`); -console.log(`linkPath: ${linkPath}`); - fs.symlink(linkData, linkPath, 'junction', common.mustCall(function(err) { assert.ifError(err); From ec7540fa908af1e544c0c1d23415fff4606d81ff Mon Sep 17 00:00:00 2001 From: AlexeyM Date: Fri, 6 Oct 2017 17:21:09 -0700 Subject: [PATCH 3/3] test: use fixtures.path helper instead of path.join --- test/parallel/test-fs-symlink-dir-junction.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-fs-symlink-dir-junction.js b/test/parallel/test-fs-symlink-dir-junction.js index 12a1c6b5c7935e..f7ba3a6d384923 100644 --- a/test/parallel/test-fs-symlink-dir-junction.js +++ b/test/parallel/test-fs-symlink-dir-junction.js @@ -27,7 +27,7 @@ const path = require('path'); const fs = require('fs'); // test creating and reading symbolic link -const linkData = path.join(fixtures.fixturesDir, 'cycles/'); +const linkData = fixtures.path('cycles/'); const linkPath = path.join(common.tmpDir, 'cycles_link'); common.refreshTmpDir();