Deprecate smalloc functions #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
The NODE_DEPRECATED macro was piggybacking on the V8_DEPRECATED macro but that macro is silent unless V8_DEPRECATION_WARNINGS is defined, something io.js doesn't do. Ergo, no deprecation notices were being issued. PR-URL: nodejs#1565 Reviewed-By: Trevor Norris <[email protected]>
The previous commit enables deprecation warnings, this commit fixes the handful of offending sites where the isolate was not explicitly being passed around. PR-URL: nodejs#1565 Reviewed-By: Trevor Norris <[email protected]>
Upcoming V8 changes will make it impossible to keep supporting the smalloc functionality so deprecate the functions in smalloc.h now and tell people to switch to typed arrays. This commit shuffles code around in smalloc.cc to avoid generating the deprecation warnings when building io.js itself. PR-URL: nodejs#1565 Reviewed-By: Trevor Norris <[email protected]>
bnoordhuis
force-pushed
the
deprecate-smalloc-functions
branch
from
18b2738
to
7306252
Compare
|
@misterdjules You should probably cherry-pick 609fa0d into joyent/node; a bug in the NODE_DEPRECATED macro stops it from actually printing deprecation warnings. |
|
@bnoordhuis Thanks for the heads up, it is very much appreciated 👍 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
The NODE_DEPRECATED macro was piggybacking on the V8_DEPRECATED macro but that macro is silent unless V8_DEPRECATION_WARNINGS is defined, something io.js doesn't do. Ergo, no deprecation notices were being issued. PR-URL: nodejs#1565 Reviewed-By: Trevor Norris <[email protected]>
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
The previous commit enables deprecation warnings, this commit fixes the handful of offending sites where the isolate was not explicitly being passed around. PR-URL: nodejs#1565 Reviewed-By: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R=@trevnorris
https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/639/