Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fixes to v1.x #1560

Merged
merged 6 commits into from
May 14, 2015
Merged

Backport fixes to v1.x #1560

merged 6 commits into from
May 14, 2015

Commits on May 14, 2015

  1. tls_wrap: use localhost if options.host is empty 

    tls.connect(options) with no options.host should accept a certificate
with CN: 'localhost'. Fix Error: Hostname/IP doesn't match
certificate's altnames: "Host: undefined. is not cert's CN: localhost"

'localhost' is not added directly to defaults because that is not
always desired (for example, when using options.socket)

PR-URL: nodejs#1493
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / a7d7463
Fixes: nodejs#1489
Reviewed-By: Brendan Ashworth <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
    @sitegui @Fishrock123
    sitegui authored and Fishrock123 committed May 14, 2015
    Configuration menu
    Copy the full SHA
    71274b0 View commit details
    Browse the repository at this point in the history

  2. test: adjust Makefile/test-ci, add to vcbuild.bat 

    PR-URL: nodejs#1530
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / 5472139
Reviewed-By: Johan Bergström <[email protected]>
    @rvagg @Fishrock123
    rvagg authored and Fishrock123 committed May 14, 2015
    Configuration menu
    Copy the full SHA
    5896fe5 View commit details
    Browse the repository at this point in the history

  3. build: remove -J from test-ci 

    parallel tests still not working on most build slaves

PR-URL: nodejs#1544
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / 2a3c8c1
Reviewed-By: Johan Bergström <[email protected]>
    @rvagg @Fishrock123
    rvagg authored and Fishrock123 committed May 14, 2015
    Configuration menu
    Copy the full SHA
    65dd10e View commit details
    Browse the repository at this point in the history

  4. string_decoder: don't cache Buffer.isEncoding 

    Some modules are monkey-patching Buffer.isEncoding, so without this
they cannot do that.

Fixes: nodejs#1547
PR-URL: nodejs#1548
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / 0fa6c4a
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
    @mscdex @Fishrock123
    mscdex authored and Fishrock123 committed May 14, 2015
    Configuration menu
    Copy the full SHA
    898d423 View commit details
    Browse the repository at this point in the history

  5. fs: validate fd on fs.write 

    PR-URL: nodejs#1553
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / f9c681c
Reviewed-By: Colin Ihrig <[email protected]>
    @julianduque @Fishrock123
    julianduque authored and Fishrock123 committed May 14, 2015
    Configuration menu
    Copy the full SHA
    4030545 View commit details
    Browse the repository at this point in the history

  6. test: extend timeouts for ARMv6 

    Based on tests running on original Raspberry Pi

PR-URL: nodejs#1554
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / f9b226c
Reviewed-By: Roman Reiss <[email protected]>
    @rvagg @Fishrock123
    rvagg authored and Fishrock123 committed May 14, 2015
    Configuration menu
    Copy the full SHA
    32a6dbc View commit details
    Browse the repository at this point in the history