Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick 0353a1e from upstream V8 #15599

Merged
merged 1 commit into from
Sep 28, 2017
Merged

deps: cherry-pick 0353a1e from upstream V8 #15599

merged 1 commit into from
Sep 28, 2017

Conversation

targos
Copy link
Member

@targos targos commented Sep 25, 2017

Original commit message:

Avoid disassembling Interpreted Regexp code

I found that v8 will crash when --print-code is turned on while Regexp
is interpreted. It crashes when trying to print Relocation info during
Disassembly. It should probably avoid printing out disassembly when the
Code object is a bytecode regexp.

Bug:
Change-Id: I35b531cb03996a303248652871452266c78fee38
Reviewed-on: https://chromium-review.googlesource.com/642127
Reviewed-by: Yang Guo <[email protected]>
Commit-Queue: Jaideep Bajwa <[email protected]>
Cr-Commit-Position: refs/heads/master@{#47718}

This is the same as #15287 for master, as the merge request was only accepted for V8 6.2.
/cc @nodejs/v8 @jBarz

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 25, 2017
@targos targos mentioned this pull request Sep 25, 2017
Closed
2 tasks
@hashseed
Copy link
Member

lgtm

@targos
Copy link
Member Author

targos commented Sep 28, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10316/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/935/

@targos
deps: cherry-pick 0353a1e from upstream V8
2f2f1cf 
Original commit message:

    Avoid disassembling Interpreted Regexp code

    I found that v8 will crash when --print-code is turned on while Regexp
    is interpreted. It crashes when trying to print Relocation info during
    Disassembly. It should probably avoid printing out disassembly when the
    Code object is a bytecode regexp.

    Bug:
    Change-Id: I35b531cb03996a303248652871452266c78fee38
    Reviewed-on: https://chromium-review.googlesource.com/642127
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Jaideep Bajwa <[email protected]>
    Cr-Commit-Position: refs/heads/master@{nodejs#47718}

PR-URL: nodejs#15599
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
Copy link
Member Author

targos commented Sep 28, 2017

Landed in 2f2f1cf

@targos targos closed this Sep 28, 2017
@targos targos deleted the backport-0353a1e branch September 28, 2017 13:58
@targos targos merged commit 2f2f1cf into nodejs:master Sep 28, 2017
@targos targos restored the backport-0353a1e branch September 28, 2017 13:58
@targos targos deleted the backport-0353a1e branch September 28, 2017 13:59
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@targos @MylesBorins
deps: cherry-pick 0353a1e from upstream V8
ec7f9ce 
Original commit message:

    Avoid disassembling Interpreted Regexp code

    I found that v8 will crash when --print-code is turned on while Regexp
    is interpreted. It crashes when trying to print Relocation info during
    Disassembly. It should probably avoid printing out disassembly when the
    Code object is a bytecode regexp.

    Bug:
    Change-Id: I35b531cb03996a303248652871452266c78fee38
    Reviewed-on: https://chromium-review.googlesource.com/642127
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Jaideep Bajwa <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#47718}

PR-URL: #15599
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
@targos @addaleax
deps: cherry-pick 0353a1e from upstream V8
9b50c56 
Original commit message:

    Avoid disassembling Interpreted Regexp code

    I found that v8 will crash when --print-code is turned on while Regexp
    is interpreted. It crashes when trying to print Relocation info during
    Disassembly. It should probably avoid printing out disassembly when the
    Code object is a bytecode regexp.

    Bug:
    Change-Id: I35b531cb03996a303248652871452266c78fee38
    Reviewed-on: https://chromium-review.googlesource.com/642127
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Jaideep Bajwa <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#47718}

PR-URL: nodejs/node#15599
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@targos @MylesBorins
deps: cherry-pick 0353a1e from upstream V8
9248768 
Original commit message:

    Avoid disassembling Interpreted Regexp code

    I found that v8 will crash when --print-code is turned on while Regexp
    is interpreted. It crashes when trying to print Relocation info during
    Disassembly. It should probably avoid printing out disassembly when the
    Code object is a bytecode regexp.

    Bug:
    Change-Id: I35b531cb03996a303248652871452266c78fee38
    Reviewed-on: https://chromium-review.googlesource.com/642127
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Jaideep Bajwa <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#47718}

PR-URL: #15599
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@targos @MylesBorins
deps: cherry-pick 0353a1e from upstream V8
6a01918 
Original commit message:

    Avoid disassembling Interpreted Regexp code

    I found that v8 will crash when --print-code is turned on while Regexp
    is interpreted. It crashes when trying to print Relocation info during
    Disassembly. It should probably avoid printing out disassembly when the
    Code object is a bytecode regexp.

    Bug:
    Change-Id: I35b531cb03996a303248652871452266c78fee38
    Reviewed-on: https://chromium-review.googlesource.com/642127
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Jaideep Bajwa <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#47718}

PR-URL: #15599
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @hashseed @bnoordhuis @jasnell @cjihrig @nodejs-github-bot