test: reduce run time for test-benchmark-http #14180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify more configuration options to reduce run time by about a third. Refs: nodejs#14177
Trott
added
benchmark
|
This appears to fix #14177. Expedite landing? @nodejs/testing @joyeecheung @refack |
joyeecheung
approved these changes
Jul 12, 2017
gibfahn
approved these changes
Jul 12, 2017
evanlucas
approved these changes
Jul 12, 2017
cjihrig
approved these changes
Jul 12, 2017
refack
approved these changes
Jul 12, 2017
| '--set', 'chunks=0', | ||
| '--set', 'dur=0.1', | ||
| '--set', 'key=""', | ||
| '--set', 'len=1', | ||
| '--set', 'n=1', | ||
| '--set', 'res=normal', |
There was a problem hiding this comment.
You can add
'--set', 'method=write',
|
Added |
|
+1 to expedite as well and thanks for jumping on top of these. |
Gotta get the CI green again before Code + Learn this weekend... :-D |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 12, 2017
Specify more configuration options to reduce run time by about a third. PR-URL: nodejs#14180 Fixes: nodejs#14177 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in daead5a |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Specify more configuration options to reduce run time by about a third. PR-URL: #14180 Fixes: #14177 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
Specify more configuration options to reduce run time by about a third. PR-URL: #14180 Fixes: #14177 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify more configuration options to reduce run time by about a third.
Refs: #14177
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark http