doc: add notice about useGlobal option in repl docs #13866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
cjihrig
approved these changes
Jun 22, 2017
doc/api/repl.md
Outdated
| @@ -406,6 +406,8 @@ changes: | |||
| * `useGlobal` {boolean} If `true`, specifies that the default evaluation | |||
| function will use the JavaScript `global` as the context as opposed to | |||
| creating a new separate context for the REPL instance. Defaults to `false`. | |||
There was a problem hiding this comment.
I think it should be adequate to say:
The CLI REPL sets this value to true. Defaults to false when used programmatically.
There was a problem hiding this comment.
I think the key point is to make readers notice the default value is false, while node CLI REPL use true in comparison.
Your suggestion is good. I try to make it less wordy.
jasnell
approved these changes
Jun 22, 2017
gibfahn
approved these changes
Jul 13, 2017
jasnell
pushed a commit
that referenced
this pull request
Jul 14, 2017
PR-URL: #13866 Fixes: #13827 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
|
Landed in 6e47e13 |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
PR-URL: #13866 Fixes: #13827 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
PR-URL: #13866 Fixes: #13827 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notice about the useGlobal option in repl docs.
Fixes: #13827
Checklist
Affected core subsystem(s)
doc