child_process: remove nextTick on IPC message #13648
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #13459 which avoided all but the first
nextTick()
on receipt of non-internal IPC messages. The reason for that was I just wanted to be more cautious in that PR. This PR however removesnextTick()
entirely as messages should always be received on future tick(s) anyway, so there shouldn't be any issues with user event handlers being executed immediately after callingfork()
, etc.Benchmark results:
CI: https://ci.nodejs.org/job/node-test-pull-request/8621/
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)