doc: edit the benchmark guide #12041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are minor typographical and style improvements to the guide for writing and running benchmarks.
Trott
added
benchmark
seishun
approved these changes
Mar 25, 2017
| can specify which benchmarker should be used. You can force a specific | ||
| benchmarker to be used by providing it as an argument, e. g.: | ||
| By default, `wrk` will be used as the benchmarker. If it is not available, | ||
| `autocannon` will be used in its place. When creating a HTTP benchmark, you can |
There was a problem hiding this comment.
That's my preference too. I'll update it. Thanks.
joyeecheung
approved these changes
Mar 26, 2017
lpinca
approved these changes
Mar 26, 2017
cjihrig
approved these changes
Mar 26, 2017
jasnell
approved these changes
Mar 26, 2017
jasnell
pushed a commit
that referenced
this pull request
Mar 27, 2017
These are minor typographical and style improvements to the guide for writing and running benchmarks. PR-URL: #12041 Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 45df578 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
These are minor typographical and style improvements to the guide for writing and running benchmarks. PR-URL: #12041 Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
|
This should not land in LTS for the same reason as #11237 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are minor typographical and style improvements to the guide for
writing and running benchmarks.
Checklist
Affected core subsystem(s)
doc benchmark