From 88eb87b7ce67f442d4fb42200ff53ea3c78a8434 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 24 Mar 2017 23:19:16 +0100 Subject: [PATCH] build: always use V8_ENABLE_CHECKS in debug mode Define `V8_ENABLE_CHECKS` in `common.gypi` for the debug mode. Without this, these checks would only be present in the object files generated from the V8 build, and so for inline functions in v8.h multiple different definitions could be generated, where one definition includes the check and the other does not. Refs: https://github.com/nodejs/node/pull/11975#discussion_r108005423 --- common.gypi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 147cc70fa5d5df..36f0dc760a8f31 100644 --- a/common.gypi +++ b/common.gypi @@ -76,7 +76,7 @@ 'variables': { 'v8_enable_handle_zapping': 1, }, - 'defines': [ 'DEBUG', '_DEBUG' ], + 'defines': [ 'DEBUG', '_DEBUG', 'V8_ENABLE_CHECKS' ], 'cflags': [ '-g', '-O0' ], 'conditions': [ ['target_arch=="x64"', {