Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase coverage of console #11653

Closed
wants to merge 1 commit into from
Closed

test: increase coverage of console #11653

wants to merge 1 commit into from

Conversation

DavidCai1111
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 2, 2017
@cjihrig
Copy link
Contributor

cjihrig commented Mar 2, 2017

Related: #11531

@hiroppy hiroppy added the console Issues and PRs related to the console subsystem. label Mar 2, 2017
@claudiorodriguez
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/6661/

mhdawson
mhdawson approved these changes Mar 2, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Mar 6, 2017

New CI run as there were failures and can't see details any more: https://ci.nodejs.org/job/node-test-pull-request/6734/

@fhinkel
Copy link
Member

fhinkel commented Mar 9, 2017

Thanks, landed in 74bd314.

@fhinkel fhinkel closed this Mar 9, 2017
fhinkel pushed a commit that referenced this pull request Mar 9, 2017
@DavidCai1111 @fhinkel
test: increase coverage of console
74bd314 
PR-URL: #11653
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 13, 2017
@DavidCai1111 @italoacasas
test: increase coverage of console
a98d963 
PR-URL: nodejs#11653
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@italoacasas italoacasas mentioned this pull request Mar 13, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@DavidCai1111 @jungx098
test: increase coverage of console
7ac0db1 
PR-URL: nodejs#11653
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
@DavidCai1111 @MylesBorins
test: increase coverage of console
d0d9c7c 
PR-URL: #11653
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@DavidCai1111 @MylesBorins
test: increase coverage of console
5a93eab 
PR-URL: #11653
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@DavidCai1111 @andrew749
test: increase coverage of console
72d357c 
PR-URL: nodejs/node#11653
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@aliscco aliscco mentioned this pull request Jun 23, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 1, 2023
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@aliscco aliscco mentioned this pull request Jan 9, 2024
Open
@leonardoadame leonardoadame mentioned this pull request Jan 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@claudiorodriguez claudiorodriguez claudiorodriguez approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@DavidCai1111 @cjihrig @claudiorodriguez @mhdawson @fhinkel @jasnell @thefourtheye @hiroppy @MylesBorins @nodejs-github-bot