Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in STYLE_GUIDE.md #11615

Merged
merged 1 commit into from
Feb 28, 2017
Merged

doc: fix typo in STYLE_GUIDE.md #11615

merged 1 commit into from
Feb 28, 2017

Conversation

seishun
Copy link
Contributor

@seishun seishun commented Feb 28, 2017

parenthesis is singular, parentheses is plural.

Checklist
Affected core subsystem(s)

doc

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it’s safe to say that this doesn’t need to wait 48 hours

@addaleax addaleax added the doc Issues and PRs related to the documentations. label Feb 28, 2017
@seishun seishun merged commit 0a44b71 into master Feb 28, 2017
@seishun seishun deleted the style-fix branch February 28, 2017 18:00
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 28, 2017
addaleax pushed a commit that referenced this pull request Mar 5, 2017
PR-URL: #11615
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@evanlucas evanlucas mentioned this pull request Mar 8, 2017
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
PR-URL: #11615
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
PR-URL: #11615
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
PR-URL: nodejs/node#11615
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants