tools: remove NODE_PATH from environment for tests #11612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unset NODE_PATH environment variable when running tests. On Ubuntu 16.04, some users experience test failures due to internal libraries being installed in /usr/lib/nodejs/internal and NODE_PATH including /usr/lib/nodejs. Tests that expect internal libraries to be off limits without the --expose-internals flag will fail in this situation. Currently, those tests are test/parallel/test-repl.js and test/parallel/test-internal-modules.js. This situation seems to (probably) be caused by some not-entirely-uncommon package that gets installed. Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is tested in test/parallel/test-module-globalpaths-nodepath.js and test/parallel/test-require-dot.js.) Refs: https://twitter.com/trott/status/835729396900061184
Trott
added
test
jasnell
approved these changes
Feb 28, 2017
bengl
approved these changes
Feb 28, 2017
richardlau
approved these changes
Mar 1, 2017
santigimeno
approved these changes
Mar 1, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 2, 2017
Unset NODE_PATH environment variable when running tests. On Ubuntu 16.04, some users experience test failures due to internal libraries being installed in /usr/lib/nodejs/internal and NODE_PATH including /usr/lib/nodejs. Tests that expect internal libraries to be off limits without the --expose-internals flag will fail in this situation. Currently, those tests are test/parallel/test-repl.js and test/parallel/test-internal-modules.js. This situation seems to (probably) be caused by some not-entirely-uncommon package that gets installed. Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is tested in test/parallel/test-module-globalpaths-nodepath.js and test/parallel/test-require-dot.js.) PR-URL: nodejs#11612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Refs: https://twitter.com/trott/status/835729396900061184
|
Landed in 22d7dc2 |
addaleax
pushed a commit
that referenced
this pull request
Mar 5, 2017
Unset NODE_PATH environment variable when running tests. On Ubuntu 16.04, some users experience test failures due to internal libraries being installed in /usr/lib/nodejs/internal and NODE_PATH including /usr/lib/nodejs. Tests that expect internal libraries to be off limits without the --expose-internals flag will fail in this situation. Currently, those tests are test/parallel/test-repl.js and test/parallel/test-internal-modules.js. This situation seems to (probably) be caused by some not-entirely-uncommon package that gets installed. Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is tested in test/parallel/test-module-globalpaths-nodepath.js and test/parallel/test-require-dot.js.) PR-URL: #11612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Refs: https://twitter.com/trott/status/835729396900061184
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2017
Unset NODE_PATH environment variable when running tests. On Ubuntu 16.04, some users experience test failures due to internal libraries being installed in /usr/lib/nodejs/internal and NODE_PATH including /usr/lib/nodejs. Tests that expect internal libraries to be off limits without the --expose-internals flag will fail in this situation. Currently, those tests are test/parallel/test-repl.js and test/parallel/test-internal-modules.js. This situation seems to (probably) be caused by some not-entirely-uncommon package that gets installed. Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is tested in test/parallel/test-module-globalpaths-nodepath.js and test/parallel/test-require-dot.js.) PR-URL: #11612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Refs: https://twitter.com/trott/status/835729396900061184
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
Unset NODE_PATH environment variable when running tests. On Ubuntu 16.04, some users experience test failures due to internal libraries being installed in /usr/lib/nodejs/internal and NODE_PATH including /usr/lib/nodejs. Tests that expect internal libraries to be off limits without the --expose-internals flag will fail in this situation. Currently, those tests are test/parallel/test-repl.js and test/parallel/test-internal-modules.js. This situation seems to (probably) be caused by some not-entirely-uncommon package that gets installed. Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is tested in test/parallel/test-module-globalpaths-nodepath.js and test/parallel/test-require-dot.js.) PR-URL: #11612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Refs: https://twitter.com/trott/status/835729396900061184
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Unset NODE_PATH environment variable when running tests. On Ubuntu 16.04, some users experience test failures due to internal libraries being installed in /usr/lib/nodejs/internal and NODE_PATH including /usr/lib/nodejs. Tests that expect internal libraries to be off limits without the --expose-internals flag will fail in this situation. Currently, those tests are test/parallel/test-repl.js and test/parallel/test-internal-modules.js. This situation seems to (probably) be caused by some not-entirely-uncommon package that gets installed. Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is tested in test/parallel/test-module-globalpaths-nodepath.js and test/parallel/test-require-dot.js.) PR-URL: nodejs/node#11612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bryan English <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Refs: https://twitter.com/trott/status/835729396900061184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unset
NODE_PATHenvironment variable when running tests.On Ubuntu 16.04, some users experience test failures due to internal
libraries being installed in
/usr/lib/nodejs/internalandNODE_PATHincluding
/usr/lib/nodejs. Tests that expect internal libraries to beoff limits without the
--expose-internalsflag will fail in thissituation. Currently, those tests are
test/parallel/test-repl.jsandtest/parallel/test-internal-modules.js.This situation seems to (probably) be caused by some
not-entirely-uncommon package that gets installed.
Regardless, tests should ignore the user's
NODE_PATH. (NODE_PATHistested in
test/parallel/test-module-globalpaths-nodepath.jsandtest/parallel/test-require-dot.js.)Refs: https://twitter.com/trott/status/835729396900061184
/cc @bengl @nodejs/testing @nodejs/build
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools test