src,test: Prepare for future V8 changes #11437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
added
lib / src
nodejs-github-bot
added
c++
evanlucas
approved these changes
Feb 17, 2017
bnoordhuis
approved these changes
Feb 17, 2017
src/node_contextify.cc
Outdated
| @@ -261,7 +264,7 @@ class ContextifyContext { | |||
| Environment* env = Environment::GetCurrent(args); | |||
| if (debug_context.IsEmpty()) { | |||
| // Force-load the debug context. | |||
| Debug::GetMirror(args.GetIsolate()->GetCurrentContext(), args[0]); | |||
| Debug::SetDebugEventListener(args.GetIsolate(), DummyDebugEventListener); | |||
There was a problem hiding this comment.
You might as well use a lambda to put things closer together:
auto dummy_event_listener = [] (const Debug::EventDetails&) {};
Debug::SetDebugEventListener(args.GetIsolate(), dummy_event_listener);Not a deal-breaker, though.
There was a problem hiding this comment.
Is it supported by all compilers?
There was a problem hiding this comment.
Yes, it's standard C++11 syntax.
jasnell
approved these changes
Feb 17, 2017
Debug::GetMirror is used in contextify to force loading of the debug context. There is a better way to achieve this. PR-URL: nodejs#11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
In later versions of V8, the stack trace will be different than our current expectations for Promise methods. PR-URL: nodejs#11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
Debug::GetMirror is used in contextify to force loading of the debug context. There is a better way to achieve this. PR-URL: #11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
In later versions of V8, the stack trace will be different than our current expectations for Promise methods. PR-URL: #11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
In later versions of V8, the stack trace will be different than our current expectations for Promise methods. PR-URL: #11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Debug::GetMirror is used in contextify to force loading of the debug context. There is a better way to achieve this. PR-URL: #11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
In later versions of V8, the stack trace will be different than our current expectations for Promise methods. PR-URL: #11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Debug::GetMirror is used in contextify to force loading of the debug context. There is a better way to achieve this. PR-URL: #11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
bbondy
pushed a commit
to brave/node
that referenced
this pull request
Mar 22, 2017
Debug::GetMirror is used in contextify to force loading of the debug context. There is a better way to achieve this. PR-URL: nodejs/node#11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
zcbenz
pushed a commit
to electron/node
that referenced
this pull request
Apr 4, 2017
Debug::GetMirror is used in contextify to force loading of the debug context. There is a better way to achieve this. PR-URL: nodejs/node#11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
bbondy
pushed a commit
to brave/node
that referenced
this pull request
Apr 9, 2017
Debug::GetMirror is used in contextify to force loading of the debug context. There is a better way to achieve this. PR-URL: nodejs/node#11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
zcbenz
pushed a commit
to electron/node
that referenced
this pull request
Apr 11, 2017
Debug::GetMirror is used in contextify to force loading of the debug context. There is a better way to achieve this. PR-URL: nodejs/node#11437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @nodejs/v8 @ofrobots @hashseed