From a045e743a0ac2fe8b8da18af482d3152ea0468ce Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Thu, 16 Feb 2017 15:52:47 -0800
Subject: [PATCH] test: enhance test-common.js

* refactor test-common.js so that global leak detection does not need to
  be disabled
* add test for common.fail()
---
 test/parallel/test-common.js | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/test/parallel/test-common.js b/test/parallel/test-common.js
index 17f41840e4ffa5..67e5e6d8b5741b 100644
--- a/test/parallel/test-common.js
+++ b/test/parallel/test-common.js
@@ -2,10 +2,14 @@
 const common = require('../common');
 const assert = require('assert');
 
-common.globalCheck = false;
+
+// test for leaked global detection
 global.gc = 42;  // Not a valid global unless --expose_gc is set.
 assert.deepStrictEqual(common.leakedGlobals(), ['gc']);
+delete global.gc;
+
 
+// common.mustCall() tests
 assert.throws(function() {
   common.mustCall(function() {}, 'foo');
 }, /^TypeError: Invalid expected value: foo$/);
@@ -13,3 +17,10 @@ assert.throws(function() {
 assert.throws(function() {
   common.mustCall(function() {}, /foo/);
 }, /^TypeError: Invalid expected value: \/foo\/$/);
+
+
+// common.fail() tests
+assert.throws(
+  () => { common.fail('fhqwhgads'); },
+  /^AssertionError: fhqwhgads$/
+);