benchmark: fix timer display in progress output #11235
Conversation
This commit fixes an issue where the minutes would not display properly on the benchmark timer once an hour had elapsed.
nodejs-github-bot
added
the
benchmark
|
What is the reason for the other changes, only |
|
@AndreasMadsen True, only minutes were calculated wrong, but because of that, seconds need to be re-calculated as well. Additionally, I could have used a temporary variable to make the adjustment once and base the minutes and seconds off of that, but I opted to just duplicate the calculations inline. |
|
I think it is fine, but I'm pretty sure that |
|
Hmm, sorry about not testing this earlier (come to think of it I could've just change the clock and observe), thanks for fixing this. I think |
This commit fixes an issue where the minutes would not display properly on the benchmark timer once an hour had elapsed. PR-URL: #11235 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
landed in a08fcc0 |
This commit fixes an issue where the minutes would not display properly on the benchmark timer once an hour had elapsed. PR-URL: nodejs#11235 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This commit fixes an issue where the minutes would not display properly on the benchmark timer once an hour had elapsed. PR-URL: #11235 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Depends on previous landed PR that has not been backported to v6 or v4. Marking as don't land on those branches. |
This commit fixes an issue where the minutes would not display properly on the benchmark timer once an hour had elapsed.
/cc @AndreasMadsen @joyeecheung
Lint: https://ci.nodejs.org/job/node-test-linter/6921/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)