url: refactor lib/internal/url.js #10912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
whatwg-url
nodejs-github-bot
added
dont-land-on-v4.x
whatwg-url
targos
approved these changes
Jan 20, 2017
joyeecheung
approved these changes
Jan 20, 2017
cjihrig
approved these changes
Jan 20, 2017
|
spelling: "consisitent" |
italoacasas
approved these changes
Jan 20, 2017
TimothyGu
approved these changes
Jan 21, 2017
TimothyGu
reviewed
Jan 21, 2017
| const length = output.reduce( | ||
| (prev, cur) => prev + cur.replace(colorRe, '').length + separator.length, | ||
| -separator.length | ||
| ); |
There was a problem hiding this comment.
This code was originally from lib/util.js, so you might be interested in changing the style there as well.
* set an identifier for the separator rather than using multiple instances of the same literal * consistent arrow function body formatting
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 23, 2017
* set an identifier for the separator rather than using multiple instances of the same literal * consistent arrow function body formatting PR-URL: nodejs#10912 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
|
Landed in 6b6123c |
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
* set an identifier for the separator rather than using multiple instances of the same literal * consistent arrow function body formatting PR-URL: #10912 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
* set an identifier for the separator rather than using multiple instances of the same literal * consistent arrow function body formatting PR-URL: nodejs#10912 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
* set an identifier for the separator rather than using multiple instances of the same literal * consistent arrow function body formatting PR-URL: nodejs#10912 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Timothy Gu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some minor nits I meant to leave on a recent pull request but didn't. /cc @TimothyGu
instances of the same literal
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url