Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: use CHECK_NE instead of ABORT or abort #10413

Merged
merged 1 commit into from
Dec 29, 2016
Merged

crypto: use CHECK_NE instead of ABORT or abort #10413

merged 1 commit into from
Dec 29, 2016

Commits on Dec 29, 2016

  1. crypto: use CHECK_NE instead of ABORT or abort 

    Use of abort() was added in 34febfb, and changed to ABORT()
in 21826ef, but conditional+ABORT() is better expressesed
using a CHECK_xxx() macro.

See: nodejs#9409 (comment)

PR-URL: nodejs#10413
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @sam-github
    sam-github committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    d9ac34c View commit details
    Browse the repository at this point in the history