v8: make ObjectMirror handle proxy objects #10409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
|
Thanks for fixing. IMO, this should be contributed upstream. The mirrors code is slated to go away soonish, but the code does exists upstream for now. /cc @hashseed. |
|
Ping. Any updates? |
|
I never got around to it because V8's debugger tests were in a severe state of flux. I'll see if I can get around to it this week, I have more patches that I need to upstream. |
|
@bnoordhuis Knowing that the Debug API is going away, I suppose upstreaming this doesn't make much sense anymore. |
|
Ah, I rather forgot about this PR. Are you suggesting I close it or that I merge it without upstreaming? I suppose it's still relevant in v6.x. |
|
I'm suggesting to merge in v6.x without upstreaming. |
|
Opened #14343 for v6.x, input welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #10406
@eugeneo @ofrobots Should I send this upstream? IIUC, mirrors are being phased out?
CI: https://ci.nodejs.org/job/node-test-pull-request/5531/
CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/476/