Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: remove unused uv_async_t #10392

Merged
merged 1 commit into from
Dec 27, 2016
Merged

inspector: remove unused uv_async_t #10392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/inspector_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ class InspectorAgentDelegate: public node::inspector::SocketServerDelegate {
class AgentImpl {
public:
explicit AgentImpl(node::Environment* env);
~AgentImpl();

// Start the inspector agent thread
bool Start(v8::Platform* platform, const char* path,
Expand Down Expand Up @@ -194,7 +193,6 @@ class AgentImpl {
State state_;
node::Environment* parent_env_;

uv_async_t* data_written_;
uv_async_t io_thread_req_;
V8NodeInspector* inspector_;
v8::Platform* platform_;
Expand Down Expand Up @@ -335,24 +333,13 @@ AgentImpl::AgentImpl(Environment* env) : delegate_(nullptr),
shutting_down_(false),
state_(State::kNew),
parent_env_(env),
data_written_(new uv_async_t()),
inspector_(nullptr),
platform_(nullptr),
dispatching_messages_(false),
session_id_(0),
server_(nullptr) {
CHECK_EQ(0, uv_sem_init(&start_sem_, 0));
memset(&io_thread_req_, 0, sizeof(io_thread_req_));
CHECK_EQ(0, uv_async_init(env->event_loop(), data_written_, nullptr));
uv_unref(reinterpret_cast<uv_handle_t*>(data_written_));
}

AgentImpl::~AgentImpl() {
auto close_cb = [](uv_handle_t* handle) {
delete reinterpret_cast<uv_async_t*>(handle);
};
uv_close(reinterpret_cast<uv_handle_t*>(data_written_), close_cb);
data_written_ = nullptr;
}

void InspectorConsoleCall(const v8::FunctionCallbackInfo<v8::Value>& info) {
Expand Down Expand Up @@ -622,7 +609,6 @@ void AgentImpl::PostIncomingMessage(InspectorAction action, int session_id,
platform_->CallOnForegroundThread(isolate,
new DispatchOnInspectorBackendTask(this));
isolate->RequestInterrupt(InterruptCallback, this);
uv_async_send(data_written_);
}
NotifyMessageReceived();
}
Expand Down Expand Up @@ -676,7 +662,6 @@ void AgentImpl::DispatchMessages() {
}
}
} while (!tasks.empty());
uv_async_send(data_written_);
dispatching_messages_ = false;
}

Expand Down