-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream, test: test for _readableState.emittedReadable #10249
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
Issues and PRs related to the tests.
lts-watch-v4.x
labels
Dec 13, 2016
joyeecheung
changed the title
stream, test: test for _readableState.needReadable
stream, test: test for _readableState.emittedReadable
Dec 13, 2016
Part of nodejs#10230, increase coverage of the internal state machine of streams.
joyeecheung
force-pushed
the
test-emitted-readable
branch
from
December 13, 2016 14:59
7ec1cf5
to
83e6738
Compare
Sorry, copied the commit message from #10241, should be |
Related to #8683 |
mcollina
approved these changes
Dec 16, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@joyeecheung can you please amend your commit and say that it is part of #8683 |
Landing |
Landed in 8127501. |
mcollina
pushed a commit
that referenced
this pull request
Dec 16, 2016
Part of #8683, increase coverage of the internal state machine of streams. PR-URL: #10249 See: #8683 See: #10230 Reviewed-By: Matteo Collina <[email protected]>
italoacasas
pushed a commit
that referenced
this pull request
Dec 17, 2016
Part of #8683, increase coverage of the internal state machine of streams. PR-URL: #10249 See: #8683 See: #10230 Reviewed-By: Matteo Collina <[email protected]>
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
Part of #8683, increase coverage of the internal state machine of streams. PR-URL: #10249 See: #8683 See: #10230 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
Part of #8683, increase coverage of the internal state machine of streams. PR-URL: #10249 See: #8683 See: #10230 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
Part of #8683, increase coverage of the internal state machine of streams. PR-URL: #10249 See: #8683 See: #10230 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Part of #8683, increase coverage of the internal state machine of streams. PR-URL: #10249 See: #8683 See: #10230 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Part of #8683, increase coverage of the internal state machine of streams. PR-URL: #10249 See: #8683 See: #10230 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
Part of #8683, increase coverage of the internal state machine of streams. PR-URL: #10249 See: #8683 See: #10230 Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
Part of #8683, increase coverage of the internal state machine of streams. PR-URL: #10249 See: #8683 See: #10230 Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
stream, test
Description of change
Part of #10230, increase coverage of the internal state machine of streams.