Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin 'configure' call fails with "Warning: Missing input files:" #8745

Closed
deragon opened this issue Sep 23, 2016 · 10 comments
Closed

Cygwin 'configure' call fails with "Warning: Missing input files:" #8745

deragon opened this issue Sep 23, 2016 · 10 comments
Labels
build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform.

Comments

@deragon
Copy link

deragon commented Sep 23, 2016

Under Cygwin (running under Windows 10), I ran the following and the output shows the error. Somehow, dependencies are missing.

# git clone git://github.com/nodejs/node
# cd node
# ./configure
creating  ./icu_config.gypi
* Using ICU in deps/icu-small
creating  ./icu_config.gypi
{ 'target_defaults': { 'cflags': [],
                       'default_configuration': 'Release',
                       'defines': [],
                       'include_dirs': [],
                       'libraries': []},
  'variables': { 'asan': 0,
                 'debug_devtools': 'node',
                 'force_dynamic_crt': 0,
                 'gas_version': '2.25',
                 'host_arch': 'x64',
                 'icu_data_file': 'icudt57l.dat',
                 'icu_data_in': '../../deps/icu-small/source/data/in/icudt57l.dat',
                 'icu_endianness': 'l',
                 'icu_gyp_path': 'tools/icu/icu-generic.gyp',
                 'icu_locales': 'en,root',
                 'icu_path': 'deps/icu-small',
                 'icu_small': 'true',
                 'icu_ver_major': '57',
                 'node_byteorder': 'little',
                 'node_enable_d8': 'false',
                 'node_enable_v8_vtunejit': 'false',
                 'node_install_npm': 'true',
                 'node_module_version': 48,
                 'node_no_browser_globals': 'false',
                 'node_prefix': '/usr/local',
                 'node_release_urlbase': '',
                 'node_shared': 'false',
                 'node_shared_cares': 'false',
                 'node_shared_http_parser': 'false',
                 'node_shared_libuv': 'false',
                 'node_shared_openssl': 'false',
                 'node_shared_zlib': 'false',
                 'node_tag': '',
                 'node_use_bundled_v8': 'true',
                 'node_use_dtrace': 'false',
                 'node_use_etw': 'true',
                 'node_use_lttng': 'false',
                 'node_use_openssl': 'true',
                 'node_use_perfctr': 'true',
                 'node_use_v8_platform': 'true',
                 'openssl_fips': '',
                 'openssl_no_asm': 0,
                 'shlib_suffix': 'so.48',
                 'target_arch': 'x64',
                 'v8_enable_gdbjit': 0,
                 'v8_enable_i18n_support': 1,
                 'v8_inspector': 'true',
                 'v8_no_strict_aliasing': 1,
                 'v8_optimized_debug': 0,
                 'v8_random_seed': 0,
                 'v8_use_snapshot': 'true',
                 'want_separate_host_toolset': 0,
                 'want_separate_host_toolset_mkpeephole': 0}}
creating  ./config.gypi
creating  ./config.mk
Warning: Missing input files:
/home/HDerago1/node/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public\V8HeapProfilerAgent.h
/home/HDerago1/node/tools\msvs\genfiles\node_etw_provider.h
/home/HDerago1/node/tools\msvs\genfiles\node_perfctr_provider.rc
/home/HDerago1/node/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/MuteConsoleScope.h
/home/HDerago1/node/tools\msvs\genfiles\node_etw_provider.rc
/home/HDerago1/node/deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public\V8EventListenerInfo.h
@mscdex
Copy link
Contributor

mscdex commented Sep 23, 2016

Node version?

@mscdex mscdex added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol labels Sep 23, 2016
@richardlau
Copy link
Member

Similar warnings about missing input files are seen in the CI, e.g. v6.6.0:
https://ci.nodejs.org/job/node-compile-windows/4158/label=win-vs2015/consoleFull

Found Visual Studio 2015
configure  --dest-cpu=x64 --tag=
Warning: Missing input files:
tools\msvs\genfiles\node_etw_provider.rc
tools\msvs\genfiles\node_etw_provider.h
deps\v8_inspector\third_party\v8_inspector\platform\v8_inspector\MuteConsoleScope.h
deps\v8_inspector\third_party\v8_inspector\platform\v8_inspector\public\V8HeapProfilerAgent.h
deps\v8_inspector\third_party\v8_inspector\platform\v8_inspector\public\V8EventListenerInfo.h
tools\msvs\genfiles\node_perfctr_provider.rc
creating  icu_config.gypi

They don't cause the build to fail though.

@eugeneo
Copy link
Contributor

eugeneo commented Sep 23, 2016

@ofrobots Rolling a new V8 Inspector is not an option, as it was moved to V8 repository now. Should I create a PR that touches files under deps/v8_inspector? Is there any special guidelines for doing that?

@deragon
Copy link
Author

deragon commented Sep 23, 2016

Node version is the most recent one, from git master branch of github.com/nodejs/node.

I ran: git clone git://github.com/nodejs/node

@ofrobots
Copy link
Contributor

@eugeneo, yes a separate PR sounds like the right approach. No special guidelines.

@eugeneo
Copy link
Contributor

eugeneo commented Sep 23, 2016

I deleted 3 obsolete entries from inspector build - #8753

I do not know if node_etw_provider.{h,rc} can be removed...

@bnoordhuis
Copy link
Member

Should be safe. They used to be checked-in pre-generated sources but as of #5657, they are always generated at build time. It's kind of odd they are written to tools/msvs instead of SHARED_INTERMEDIATE_DIR, though.

@embray
Copy link

embray commented Jan 19, 2017

As I understand it, having recently encountered a similar problem, support for Cygwin has been "removed" (if it was ever really there in the first place). This seems unfortunate because there's no reason it can't be built on Cygwin.

The main reason for this seems to be that NodeJS is using a build system unfortunately named "gyp" (seriously?!) which it seems to me doesn't support Cygwin correctly, and conflates it too much with Windows. Really Cygwin should be treated as its own OS closer to Linux in terms of what the build system should look like, and should not be treated as "Windows" at all.

@bnoordhuis
Copy link
Member

Seems we forgot to close this out after #8753 landed. I'll do it now.

This seems unfortunate because there's no reason it can't be built on Cygwin.

@embray Neither V8 nor libuv really support cygwin (libuv not at all, third class in V8), therefore neither does node.

@embray
Copy link

embray commented Jan 19, 2017

Too bad; not your fault though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

7 participants