node --inspect fire Runtime.executionContextDestroyed when script finishes executing

[nojvek]

• Version: Node nightly
• Platform:
• Subsystem:

Reported in chromium : https://bugs.chromium.org/p/chromium/issues/detail?id=628407

But it seems this needs to be fixed in node according to @pavelfeldman

This is where we should call V8Debugger::contextDestroyed
https://github.com/nodejs/node/blob/master/src/node.cc#L2178.

[nojvek]

Would the fix be along the lines of:

void AgentImpl::WaitForDisconnect() {
  shutting_down_ = true;
  fprintf(stderr, "Waiting for the debugger to disconnect...\n");
  inspector_->contextDestroyed(inspector_->rootContext);
  inspector_->runMessageLoopOnPause(0);
}

I could attempt a fix

/cc @ofrobots

[ofrobots]

Sounds good /cc @eugeneo.

[pavelfeldman]

Would the fix be along the lines of

Sort of. It seems you might need to land the plumbing for the contextDestroyed into V8Inspector which is in Blink to achieve that. You can fix it in terms of Node and we'll help with the two-sided commit.

[nojvek]

PR #7756