Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8_inspector: url field is missed #7245

Closed
develar opened this issue Jun 9, 2016 · 6 comments
Closed

v8_inspector: url field is missed #7245

develar opened this issue Jun 9, 2016 · 6 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@develar
Copy link

develar commented Jun 9, 2016

  • Version:
    master
  • Platform:
    OS X
  • Subsystem:
    inspector

node --inspect=9229 --debug-brk foo.js

Actual:

{
  "description": "node.js instance",
  "devtoolsFrontendUrl": "https://chrome-devtools-frontend.appspot.com/serve_file/@521e5b7e2b7cc66b4006a8a54cb9c4e57494a5ef/inspector.html?experiments=true&v8only=true&ws=localhost:9229/node",
  "faviconUrl": "https://nodejs.org/static/favicon.ico",
  "id": "44439",
  "title": "/Volumes/hdd/node/out/Release/node",
  "type": "node",
  "webSocketDebuggerUrl": "ws://localhost:9229/node"
}

Expected: url is missed — should be file path.

NPE in the JetBrains Debugger (Chromium Remote run configuration in the JetBrains IDEs can be used to debug node).

@bnoordhuis
Copy link
Member

Isn't that a JetBrains bug? node --inspect=9229 --debug-brk -e 'require("./")' won't have a file path. It should be prepared to deal with that.

@develar
Copy link
Author

develar commented Jun 9, 2016

Yes, it is a JetBrains bug and it will be fixed. But to be consistent, url should be set to some path. And for -e case maybe we can set it to <eval>.

For example, Google Chrome set url to "chrome://newtab/" for new tab (e.g. if you run javascript: some code).

@mscdex mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Jun 9, 2016
@eugeneo
Copy link
Contributor

eugeneo commented Jun 10, 2016

I made several fixes and can see basic debug working in the WebStorm - https://github.com/eugeneo/node/tree/webstorm

I will need to test it on Windows though. There are also some issues that we do not want to "fix" - I will try to contact JetBrains to describe incompatibilities.

@eugeneo
Copy link
Contributor

eugeneo commented Jun 10, 2016

I opened WebStorm bug here - https://youtrack.jetbrains.com/issue/WEB-21991

I described 2 incompatibilities that are WebStorm issues.

@eugeneo
Copy link
Contributor

eugeneo commented Sep 14, 2016

#8243 added the URL field. This issue can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

5 participants
@mscdex @bnoordhuis @eugeneo @develar and others