Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--env-file-if-exists is in the wrong spot in the docs #55129

Closed
BoscoDomingo opened this issue Sep 26, 2024 · 3 comments · Fixed by #55131
Closed

--env-file-if-exists is in the wrong spot in the docs #55129

BoscoDomingo opened this issue Sep 26, 2024 · 3 comments · Fixed by #55131
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. dotenv Issues and PRs related to .env file parsing good first issue Issues that are suitable for first-time contributors.

Comments

@BoscoDomingo
Copy link
Contributor

Affected URL(s)

https://nodejs.org/docs/latest/api/cli.html#--env-file-if-existsconfig

Description of the problem

Because the flag was originally --optional-env-file I forgot to move it after renaming it, so it is still in that spot in the documentation. It should be placed right under --env-file instead, and should be an extremely easy fix.

Related #53060
@BoscoDomingo BoscoDomingo added the doc Issues and PRs related to the documentations. label Sep 26, 2024
@RedYetiDev
Copy link
Member

Would you like to submit a PR fixing it?

@RedYetiDev RedYetiDev added good first issue Issues that are suitable for first-time contributors. cli Issues and PRs related to the Node.js command line interface. dotenv Issues and PRs related to .env file parsing labels Sep 26, 2024
@geeksilva97
Copy link
Contributor

I can take it.

@geeksilva97 geeksilva97 mentioned this issue Sep 26, 2024
Merged
@BoscoDomingo
Copy link
Contributor Author

I can take it.

Appreciate it! (I have limited time during the week)

targos pushed a commit that referenced this issue Oct 4, 2024
@geeksilva97 @targos
doc: put --env-file-if-exists=config right under --env-file=config
4bd3c2f 
PR-URL: #55131
Fixes: #55129
Refs: #53060
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this issue Oct 4, 2024
@geeksilva97 @targos
doc: put --env-file-if-exists=config right under --env-file=config
7186ede 
PR-URL: #55131
Fixes: #55129
Refs: #53060
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
@geeksilva97 @louwers
doc: put --env-file-if-exists=config right under --env-file=config
d3bc007 
PR-URL: nodejs#55131
Fixes: nodejs#55129
Refs: nodejs#53060
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
@geeksilva97 @tpoisseau
doc: put --env-file-if-exists=config right under --env-file=config
bbc158d 
PR-URL: nodejs#55131
Fixes: nodejs#55129
Refs: nodejs#53060
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. dotenv Issues and PRs related to .env file parsing good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: put --env-file-if-exists=config right under --env-file=config geeksilva97/node
3 participants
@geeksilva97 @RedYetiDev @BoscoDomingo