test: child-process-fork-regr-gh-2847 is flaky still

[mscdex]

Example CI run on ppcbe-fedora20.

/cc @santigimeno @Trott

[santigimeno]

@mscdex can you copy the output please? Thanks

[mscdex]

Here it is:

not ok 51 test-child-process-fork-regr-gh-2847.js
# events.js:155
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: connect ECONNREFUSED 127.0.0.1:12346
#     at Object.exports._errnoException (util.js:859:11)
#     at exports._exceptionWithHostPort (util.js:882:20)
#     at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1059:14)

[santigimeno]

It looks that these lines that I removed in the last refactoring are still relevant:

node/test/parallel/test-child-process-fork-regr-gh-2847.js

Lines 40 to 52 in 30c0062

	// Errors can happen if the connections
	// are still happening while the server has been closed.
	// This can happen depending on how the messages are
	// bundled into packets. If they all make it into the first
	// one then no errors will occur, otherwise the server
	// may have been closed by the time the later ones make
	// it to the server side.
	// We ignore any errors that occur after some connections
	// get through
	s.on('error', function(err) {
	if (connectcount < 3)
	console.log(err);
	});

. Is the error reproducible in the CI?

[Trott]

@santigimeno Reproducible in CI. https://ci.nodejs.org/job/node-stress-single-test/518/nodes=ppcbe-fedora20/console. Results so far: 115 failures in 2444 runs. Failures look like:

not ok 1 test-child-process-fork-regr-gh-2847.js
# events.js:155
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: connect ECONNREFUSED 127.0.0.1:12346
#     at Object.exports._errnoException (util.js:859:11)
#     at exports._exceptionWithHostPort (util.js:882:20)
#     at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1059:14)

[santigimeno]

I have submitted a tentative fix here: #5422. Could somebody check in the CI if it fixes the issue? Thanks!