You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When detect-module is enabled by default (as seen in this image), we're encountering failures in several tests from test/es-module. While most of these failures are expected due to the changes, two of them are not:
These errors seem to be related to how the format context property is defined. We've attempted various solutions, but we're seeking input on the next steps on how to properly define this property.
Some ideas we're considering:
Ensure format is always defined: We could make sure format is never undefined, even if we don't know what it should be.
Pros:
Eliminates concerns about different edge cases for return types.
Avoids the need to redefine format multiple times internally.
Cons:
If we don't know the format, what value should we set it to?
Distinguish null and undefined formats: Specifically for this use case, we could differentiate between null and undefined formats.
Pros:
Could work well for our purposes.
Requires minimal effort to implement.
Cons:
Maintenance could be challenging, as future changes would need to understand this distinction.
Do you have any insights or suggestions on these approaches, or perhaps an alternative solution we haven't considered?
The text was updated successfully, but these errors were encountered:
RedYetiDev
added
help wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
module
Issues and PRs related to the module subsystem.
loaders
Issues and PRs related to ES module loaders
labels
May 15, 2024
When
detect-module
is enabled by default (as seen in this image), we're encountering failures in several tests fromtest/es-module
. While most of these failures are expected due to the changes, two of them are not:These errors seem to be related to how the
format
context property is defined. We've attempted various solutions, but we're seeking input on the next steps on how to properly define this property.Some ideas we're considering:
Ensure
format
is always defined: We could make sureformat
is neverundefined
, even if we don't know what it should be.format
multiple times internally.Distinguish
null
andundefined
formats: Specifically for this use case, we could differentiate betweennull
andundefined
formats.Do you have any insights or suggestions on these approaches, or perhaps an alternative solution we haven't considered?
The text was updated successfully, but these errors were encountered: