Feature request: A way to mock module, require

[qfox]

There is a commit in [email protected] that modified behaviour of require: #1801

I understand that this is a major release but some of very handy modules doesn't work now.

• Require error with [email protected] tschaub/mock-fs#43
• Does not work on Node 5.4 bahmutov/really-need#31

For me it looks like we need some legal way (public API) for mocking module, require, and so on.

I guess I can make a PR if you point me.

Related #4190

[bnoordhuis]

Why don't you copy lib/module.js into your own project and patch it up so that it can run outside of core? I think it's highly unlikely we'd commit to an official monkey-patch API, particularly when it's something that can be solved through a third-party module.

[qfox]

The only reason why I don't copied lib/module: I'm scared of outdating and inconsistency.

We have methods like Module._load, Module._resolveFilename, but there is no method for stat.

I don't see right now how to do it via third party module except copying almost the whole module and fixing right there ;-(.

Here's a cute example: https://github.com/KoryNunn/rooty/blob/master/index.js

[bnoordhuis]

The public API and the algorithm are fixed. If they ever need to change, it's going to be a semver-major change at the very least so you'll have plenty of time and advance warning.

[qfox]

Sounds reasonable...

And I've just found another comment about monkey patching. #1801 (comment)

And I'm agree that we shouldn't make useless code.

But lib/module consists of code that could be better unique. If we'll copy it each time we need a new module, we'll get modules like https://github.com/shz/node-require-internal/blob/master/lib/require.js and https://github.com/boblauer/mock-require/blob/master/index.js

This feature request is more like about an ecosystem for mocking module than just monkey patching lib/module in core. Because this situation where we should monkey patch lib/module from user-space code every time without any guarantees (because we patching private methods) is totally crazy.

At least would be great to have some recommendations on mocking core functionality on purpose.

[blond]

👍

[tadatuta]

👍

[MauriceButler]

Changing the behavior of require is not terribly difficult in userland I have done it a few times (Im am the author of the above mentioned rooty && rootify )

If it is mocking or changing of apis at runtime you need something like these might help.

fraudster <- Overrides require (Disclaimer another one of my modules)

proxyquire <- Has some good functionality but provides another method to use instead of require

If you are looking for something else that one of these modules dont solve let me know I am happy to help.

[dead-claudia]

There's also mockery.

[sipayRT]

👍

[vkurchatkin]

You don't need monkey-patching for this. Node provides module loader for CommonJS format, you can provide your own with all the functionality you want. It's much safer than patching Module prototype, Module is not supposed to be used at all.

[vkurchatkin]

To summarise it all:

The only reason why I don't copied lib/module: I'm scared of outdating and inconsistency.

Don't be: algorithm is very stable and fixed. You might not get some performance enhancements, but that's not what you are after anyway.

We have methods like Module._load, Module._resolveFilename, but there is no method for stat.

But you shouldn't use them or patch them. While module system is locked, implementation details can change and these methods can stop doing what you think they do or be removed entirely. Copying the code is just fine.

I don't see right now how to do it via third party module except copying almost the whole module and fixing right there ;-(.

That's exactly how you'd do it, or you can rewrite it from scratch, if you wish. It shouldn't be that hard and you can reuse existing tests to verify compatibility.

[cjihrig]

Closing as this seems very unlikely to make it into core.