Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GN build without using depot_tools #51689

Open
zcbenz opened this issue Feb 7, 2024 · 3 comments
Open

Support GN build without using depot_tools #51689

zcbenz opened this issue Feb 7, 2024 · 3 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@zcbenz
Copy link
Contributor

zcbenz commented Feb 7, 2024

The GN build is documented at #51676, which however requires using depot_tools from Chromium for building, and the code of Node must be checked out in a specific directory structure.

To simplify the GN build for developers who don't work with Chromium, there has been an effort to make GN work without depot_tools:

There are a few problems left for solving:

  • Maintaining the forked GN is a burden.
  • Even without the requirement of depot_tools, the GN build of V8 requires the following dependencies to exist:
    • abseil-cpp
    • icu
    • jinja2
    • markupsafe
    • zlib
  • The default configurations of V8 does not work with Node, and we must explicitly pass a list of GN args when generating the build files.
@targos
Copy link
Member

targos commented Feb 7, 2024

the GN build of V8 requires the following dependencies to exist

Is it an issue even though we include the source of these dependencies in our tree?

@zcbenz
Copy link
Contributor Author

zcbenz commented Feb 7, 2024

The GN files of V8 hardcodes paths to some dependencies to //third_party/xxx, I need to add args to allow changing them to //node/deps/xxx to fix them.

@targos
Copy link
Member

targos commented Feb 7, 2024

OK for icu. The other ones are in the third_party directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

No branches or pull requests

3 participants