Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

../deps/v8/src/codegen/riscv/assembler-riscv-inl.h:162:12: error: no declaration matches 'v8::internal::HeapObject v8::internal::RelocInfo::target_object(v8::internal::PtrComprCageBase)' #50633

Closed
andreas-schwab opened this issue Nov 9, 2023 · 5 comments
Labels
riscv64 Issues and PRs related to the riscv64 architecture. v8 engine Issues and PRs related to the V8 dependency.

Comments

@andreas-schwab
Copy link
Contributor

andreas-schwab commented Nov 9, 2023

../deps/v8/src/codegen/riscv/assembler-riscv-inl.h:162:12: error: no declaration matches 'v8::internal::HeapObject v8::internal::RelocInfo::target_object(v8::internal::PtrComprCageBase)'
162 | HeapObject RelocInfo::target_object(PtrComprCageBase cage_base) {
| ^~~~~~~~~
In file included from ../deps/v8/src/codegen/assembler.h:52,
from ../deps/v8/src/codegen/assembler-arch.h:8,
from ../deps/v8/src/codegen/macro-assembler-base.h:12:
../deps/v8/src/codegen/reloc-info.h:318:32: note: candidate is: 'v8::internal::Taggedv8::internal::HeapObject v8::internal::RelocInfo::target_object(v8::internal::PtrComprCageBase)'
318 | V8_INLINE Tagged target_object(PtrComprCageBase cage_base);
| ^~~~~~~~~~~~~
../deps/v8/src/codegen/reloc-info.h:92:7: note: 'class v8::internal::RelocInfo' defined here
92 | class RelocInfo {
| ^~~~~~~~~
../deps/v8/src/codegen/riscv/assembler-riscv-inl.h:189:6: error: no declaration matches 'void v8::internal::RelocInfo::set_target_object(v8::internal::HeapObject, v8::internal::ICacheFlushMode)'
189 | void RelocInfo::set_target_object(HeapObject target,
| ^~~~~~~~~
../deps/v8/src/codegen/reloc-info.h:327:18: note: candidates are: 'void v8::internal::RelocInfo::set_target_object(v8::internal::Taggedv8::internal::HeapObject, v8::internal::ICacheFlushMode)'
327 | V8_INLINE void set_target_object(
| ^~~~~~~~~~~~~~~~~
../deps/v8/src/codegen/reloc-info.h:322:18: note: 'void v8::internal::RelocInfo::set_target_object(v8::internal::Taggedv8::internal::InstructionStream, v8::internal::Taggedv8::internal::HeapObject, v8::internal::WriteBarrierMode, v8::internal::ICacheFlushMode)'
322 | V8_INLINE void set_target_object(
| ^~~~~~~~~~~~~~~~~
../deps/v8/src/codegen/reloc-info.h:92:7: note: 'class v8::internal::RelocInfo' defined here
92 | class RelocInfo {
| ^~~~~~~~~
make[1]: *** [tools/v8_gypfiles/v8_compiler.target.mk:288: /home/abuild/rpmbuild/BUILD/node-v21.1.0/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/backend/code-generator.o] Error 1

@targos
Copy link
Member

targos commented Nov 9, 2023

@nodejs/platform-riscv64

@targos targos added v8 engine Issues and PRs related to the V8 dependency. riscv64 Issues and PRs related to the riscv64 architecture. labels Nov 9, 2023
@andreas-schwab
Copy link
Contributor Author

@luyahan
Copy link
Contributor

luyahan commented Nov 10, 2023

What's your commit ?
I build riscv pass on commit 3e14cfb.

@andreas-schwab
Copy link
Contributor Author

v21.1.0

@luyahan
Copy link
Contributor

luyahan commented Nov 10, 2023

v21.1.0

The next release will be fixed, see:
#50648 (comment)

@targos targos closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
riscv64 Issues and PRs related to the riscv64 architecture. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

3 participants