Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8 patch update workflow is broken #50497

Closed
targos opened this issue Nov 1, 2023 · 18 comments · Fixed by #52822 or #52844
Closed

V8 patch update workflow is broken #50497

targos opened this issue Nov 1, 2023 · 18 comments · Fixed by #52822 or #52844
Labels
tools Issues and PRs related to the tools directory.

Comments

@targos
Copy link
Member

targos commented Nov 1, 2023

See https://github.com/nodejs/node/actions/runs/6680065519/job/18152806998

It's not clear why it fails. There's no error message in the output.

/cc @marco-ippolito
@targos targos added the tools Issues and PRs related to the tools directory. label Nov 1, 2023
@marco-ippolito
Copy link
Member

marco-ippolito commented Nov 1, 2023 •
edited
Loading

Could it be a timeout?
It's failing consistently
cc @nodejs/security-wg

@targos
Copy link
Member Author

targos commented Nov 1, 2023 •
edited
Loading

Note it doesn't fail on my computer:

$ ./tools/dep_updaters/update-v8-patch.sh
Skipped because V8 is on the latest version.

@targos
Copy link
Member Author

targos commented Nov 1, 2023

Yes, it's been failing consistently for some time.
Here are the commits between the last successful run and the first failure: 718f62b...ff14b24

@marco-ippolito
Copy link
Member

marco-ippolito commented Nov 1, 2023 •
edited
Loading

Note it doesn't fail on my computer:

$ ./tools/dep_updaters/update-v8-patch.sh
Skipped because V8 is on the latest version.

same for me, I can create a branch and remove the pipe to temp output so we should see in the action as it runs

./tools/dep_updaters/update-v8-patch.sh > temp-output

@marco-ippolito
Copy link
Member

https://github.com/nodejs/node/actions/runs/6717612045/job/18255788737
with this change (./tools/dep_updaters/update-v8-patch.sh > temp-output), it works 🤔
main...do-not-merge/fix-update-v8-action

@targos
Copy link
Member Author

targos commented Nov 1, 2023

Can you try again with echo statements between each line so we have an idea about when it fails?

@marco-ippolito
Copy link
Member

marco-ippolito commented Nov 1, 2023 •
edited
Loading

now it worked on main 🤔
https://github.com/nodejs/node/actions/workflows/update-v8.yml
that's 100% weird, on other branch it worked fine too
could be git node v8 minor failing network calls?

@aduh95
Copy link
Contributor

aduh95 commented Nov 1, 2023

Could be related to nodejs/node-core-utils#722 😞

@targos
Copy link
Member Author

targos commented Nov 1, 2023

Not sure. It's been failing consistently since June.

@targos
Copy link
Member Author

targos commented Nov 21, 2023

Now there's an update and it fails: https://github.com/nodejs/node/actions/runs/6945894914/job/18896335828

@marco-ippolito
Copy link
Member

@targos should we add some logging to the script/action?

@targos
Copy link
Member Author

targos commented Nov 23, 2023

Probably.

@marco-ippolito
Copy link
Member

marco-ippolito commented Nov 28, 2023 •
edited
Loading

@nodejs/node-core-utils
maybe related to nodejs/node-core-utils#743, it also fails for git node v8 minor
The fails seems not to be consistent anymore but using a previous version 3.3.0 gives an output
https://github.com/nodejs/node/actions/runs/7016406093/job/19087566216
while using >4.0.0 no error message

@targos
Copy link
Member Author

targos commented Nov 28, 2023

Ok, so the ncu bug is that it swallows the error message.
The problem of the workflow is that it doesn't set Git name and email before running the update script.

@marco-ippolito
Copy link
Member

marco-ippolito commented Nov 29, 2023 •
edited
Loading

setting explicitly user and email doesnt seem to fix it 😨 https://github.com/nodejs/node/actions/runs/7030498961/job/19130153818,
run removing cache:
https://github.com/nodejs/node/actions/runs/7030618696/job/19130514557
this is 100% related to nodejs/node-core-utils#743

@aduh95
Copy link
Contributor

aduh95 commented Nov 29, 2023

this is 100% related to nodejs/node-core-utils#743

It seems it's not the case, the other issue has been fixed, yet the workflow still fails here 🤔 Also #50497 (comment) is good indication that something else is wrong.

@targos targos mentioned this issue May 3, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue May 5, 2024
@aduh95
tools: fix V8 update workflow
38ef4e5 
PR-URL: #52822
Fixes: #50497
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos
Copy link
Member Author

targos commented May 5, 2024

Still broken after #52822:

https://github.com/nodejs/node/actions/runs/8958621255/job/24603051286

@targos targos reopened this May 5, 2024
@aduh95
Copy link
Contributor

aduh95 commented May 5, 2024 •
edited
Loading 

Error: Command failed with exit code 1 (EPERM): git commit -m 'Update from 'Create or Update Request' action' --author 'Node.js GitHub Bot <[email protected]>'

Looks like the commit message is not correctly escaped (git commit -m 'Update from 'Create or Update Request' action'), related to gr2m/create-or-update-pull-request-action#280

@aduh95 aduh95 mentioned this issue May 5, 2024
Merged
nodejs-github-bot pushed a commit that referenced this issue May 5, 2024
@aduh95
tools: specify a commit-message for V8 update workflow
c6f8e18 
PR-URL: #52844
Fixes: #50497
Refs: gr2m/create-or-update-pull-request-action#280
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this issue May 8, 2024
@aduh95
tools: fix V8 update workflow
fd5da46 
PR-URL: nodejs#52822
Fixes: nodejs#50497
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this issue May 8, 2024
@aduh95
tools: specify a commit-message for V8 update workflow
850aff0 
PR-URL: nodejs#52844
Fixes: nodejs#50497
Refs: gr2m/create-or-update-pull-request-action#280
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this issue May 8, 2024
@aduh95 @targos
tools: fix V8 update workflow
317998a 
PR-URL: #52822
Fixes: #50497
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this issue May 8, 2024
@aduh95 @targos
tools: specify a commit-message for V8 update workflow
1ee38a5 
PR-URL: #52844
Fixes: #50497
Refs: gr2m/create-or-update-pull-request-action#280
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
marco-ippolito pushed a commit that referenced this issue Jun 17, 2024
@aduh95 @marco-ippolito
tools: fix V8 update workflow
b83fbf8 
PR-URL: #52822
Fixes: #50497
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit that referenced this issue Jun 17, 2024
@aduh95 @marco-ippolito
tools: specify a commit-message for V8 update workflow
8f8fb91 
PR-URL: #52844
Fixes: #50497
Refs: gr2m/create-or-update-pull-request-action#280
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
sophonieb pushed a commit to sophonieb/node that referenced this issue Jun 20, 2024
@aduh95 @sophonieb
tools: fix V8 update workflow
04456ce 
PR-URL: nodejs#52822
Fixes: nodejs#50497
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sophonieb pushed a commit to sophonieb/node that referenced this issue Jun 20, 2024
@aduh95 @sophonieb
tools: specify a commit-message for V8 update workflow
eee57f9 
PR-URL: nodejs#52844
Fixes: nodejs#50497
Refs: gr2m/create-or-update-pull-request-action#280
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@aduh95 @bmeck
tools: fix V8 update workflow
b8f04fe 
PR-URL: nodejs#52822
Fixes: nodejs#50497
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@aduh95 @bmeck
tools: specify a commit-message for V8 update workflow
009582a 
PR-URL: nodejs#52844
Fixes: nodejs#50497
Refs: gr2m/create-or-update-pull-request-action#280
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
3 participants
@targos @aduh95 @marco-ippolito