Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need LazyTransform? #50439

Closed
ronag opened this issue Oct 28, 2023 · 3 comments
Closed

Do we need LazyTransform? #50439

ronag opened this issue Oct 28, 2023 · 3 comments

Comments

@ronag
Copy link
Member

ronag commented Oct 28, 2023

I'm a little unsure about the purpose of LazyTransform and whether it actually makes any relevant performance difference.

Any thoughts on whether it would be ok to just replace it with a normal Transform in e..g crypto?
@ronag
Copy link
Member Author

ronag commented Oct 28, 2023

@mcollina @jasnell @nodejs/streams @nodejs/crypto

@mcollina
Copy link
Member

Yes, I think we do, unless benchmarks tells that the cost of creating a full transform is gone.

@ronag
Copy link
Member Author

ronag commented Oct 28, 2023

With the latest stream optimizations all merged in I don't see any relevant difference. Will open a PR.

@ronag ronag mentioned this issue Oct 28, 2023
Closed
ronag added a commit to nxtedition/node that referenced this issue Oct 28, 2023
@ronag
stream: remove LazyTransform
efdea70 
No longer necessary given recent stream and event optimziations.

Refs: nodejs#50428
Refs: nodejs#50439

PR-URL: nodejs#50440
ronag added a commit to nxtedition/node that referenced this issue Oct 28, 2023
@ronag
stream: remove LazyTransform
9bf65a3 
No longer necessary given recent stream and event optimziations.

Refs: nodejs#50428
Refs: nodejs#50439
ronag added a commit to nxtedition/node that referenced this issue Oct 28, 2023
@ronag
stream: remove LazyTransform
5fe2816 
No longer necessary given recent stream and event optimziations.

Refs: nodejs#50428
Refs: nodejs#50439

PR-URL: nodejs#50440
ronag added a commit to nxtedition/node that referenced this issue Oct 28, 2023
@ronag
stream: remove LazyTransform
d9f2770 
No longer necessary given recent stream and event optimziations.

Refs: nodejs#50428
Refs: nodejs#50439

PR-URL: nodejs#50440
ronag added a commit to nxtedition/node that referenced this issue Oct 29, 2023
@ronag
stream: remove LazyTransform
06c89b4 
No longer necessary given recent stream and event optimziations.

Refs: nodejs#50428
Refs: nodejs#50439

PR-URL: nodejs#50440
ronag added a commit to nxtedition/node that referenced this issue Oct 29, 2023
@ronag
stream: remove LazyTransform
2bad63b 
No longer necessary given recent stream and event optimziations.

Refs: nodejs#50428
Refs: nodejs#50439

PR-URL: nodejs#50440
ronag added a commit to nxtedition/node that referenced this issue Oct 29, 2023
@ronag
stream: remove LazyTransform
3bab912 
No longer necessary given recent stream and event optimziations.

Refs: nodejs#50428
Refs: nodejs#50439

PR-URL: nodejs#50440
ronag added a commit to nxtedition/node that referenced this issue Oct 30, 2023
@ronag
stream: remove LazyTransform
c249549 
No longer necessary given recent stream and event optimziations.

Refs: nodejs#50428
Refs: nodejs#50439

PR-URL: nodejs#50440
@ronag ronag closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @ronag