Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer libdir and mandir configure options. #504

Closed
ryanpcmcquen opened this issue Jan 19, 2015 · 8 comments
Closed

Offer libdir and mandir configure options. #504

ryanpcmcquen opened this issue Jan 19, 2015 · 8 comments
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js.

Comments

@ryanpcmcquen
Copy link

I currently have a SlackBuild in pending for io.js, I am very excited to bring this great project to Slackware!

I would like to request this enhancement to packaging io.js, if feasible ... to get around being unable to change the library and man paths, I currently have this in the Slackware build script:

# Fix man page path.
sed -i 's|share/||' tools/install.py
sed -i '/var manRoot/ s/"share",//' deps/npm/lib/{,un}build.js

# Fix libdir for 64-bit.
sed -i "s|lib/|lib${LIBDIRSUFFIX}/|g" tools/install.py
sed -i "s/'lib'/'lib${LIBDIRSUFFIX}'/" lib/module.js
sed -i "s|\"lib\"|\"lib${LIBDIRSUFFIX}\"|" deps/npm/lib/npm.js

It'd be nice if io.js offered a typical configure flag option like --libdir and --mandir.

Thanks!

@jbergstroem
Copy link
Member

I can probably create a patch for this, but as you mention, {,un}build.js and npm.js from npm doesn't seem to be customisable either (just prefix), so you should probably file (with patch if possible) a request over at the npm tracker if one doesn't already exist.

To be honest, I think packagers are in the best position to cater this issue for now.

@bnoordhuis
Copy link
Member

FWIW, I have some (old) commits that add --libdir and --mandir switches but I never upstreamed them. I wrote that when I was working on an RPM package but I ended up just dealing with it inside the .spec file.

bnoordhuis/node@e0bffc4 configure, install: add --mandir configure switch
bnoordhuis/node@63abdfe configure, install: add --libdir configure switch
bnoordhuis/node@2d3cebe install: prepare for configurable libdir/mandir

@ryanpcmcquen
Copy link
Author

There was already an issue for npm that didn't get too far, so I've commented on that instead:

npm/npm#1112

@ryanpcmcquen
Copy link
Author

That one may be too unrelated, I've decided to start a new issue instead:

npm/npm#7166

@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Mar 12, 2015
@brendanashworth brendanashworth added the feature request Issues that request new features to be added to Node.js. label Jun 13, 2015
@Trott
Copy link
Member

Trott commented Jan 19, 2016

Just pinging some old issues to confirm that they should remain open. Hi. Is this still A Thing?

@ryanpcmcquen
Copy link
Author

Yeah, this still needs to happen, unfortunately I have not gotten to it. 😞

@jbergstroem
Copy link
Member

How about we close it and anyone that wants to create the feature can just PR?

@ryanpcmcquen
Copy link
Author

Works for me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Development

No branches or pull requests

6 participants