-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ibmi: parallel/test-runner-watch-mode fails with timeout #48065
Comments
Looks like the regex was changed in: 9c61d41#diff-6c0e8227fa88dafb16ddbf9e6432c6b0d27cc6a74e5d03e7ed8665dee363bf40 |
This might be a duplicate of #44898, which is not specific to ibmi. |
There still seems to be an issue after the fix. This test case is currently failing on the nightly CI: https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1191/testReport/ Can we reopen this issue until its resolved? |
I seem to have misunderstood - imbi does not run as part of |
AFAIK it does not. The CI was in bad shape and I've been working on getting things in better state. |
https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1159/testReport/(root)/test/parallel_test_runner_watch_mode/
Not much to go off in the test result so here is the console output:
So the failure is caused due to a timeout.
I ran the test manually adding a some console logs for debug purposes
Log child process stdout
Add Log to print the args the child process was spawned with
Add logs at the beginning of each test case to know which one we are in.
node/test/parallel/test-runner-watch-mode.mjs
Line 32 in 3538e1b
node/test/parallel/test-runner-watch-mode.mjs
Line 38 in 3538e1b
node/test/parallel/test-runner-watch-mode.mjs
Line 45 in 3538e1b
The test case hangs here.
Looks like we are in the first test case.
The child was spawned was spawned with:
To isolate the outputs from each I ran them seperately:
node/test/fixtures/test-runner/index.test.js
Line 4 in 3538e1b
node/test/fixtures/test-runner/dependent.js
Line 5 in 10b21e5
The code in the test case has a regex to match
- test has ran
to determine when to resolve each promise.node/test/parallel/test-runner-watch-mode.mjs
Lines 17 to 19 in 10b21e5
We get one match from
fixtures/test-runner/dependent.js
butfixtures/test-runner/index.test.js
logsthis should pass
.Therefore the second promise never gets resolved causing the timeout.
Is there something wrong with the regex check? Should it be looking for
this should pass
as well?Or is there some other issue?
CC @richardlau
CC @nodejs/platform-ibmi
The text was updated successfully, but these errors were encountered: