-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api docs scrolling and anchors appear broken #47858
Comments
I will work on this one. |
Note that this issue is not an issue of the Website repository, neither for the Website Team. The related code is placed at @harshitphoenix feel free to work on them, but they might not be as easy as you think. The 2nd one for example is quite tricky. I'm moving this issue to https://github.com/nodejs/node repository as it should belong there. |
I've just found the culprit of the 1st bug, which seems to be related due the styling of content-visibility: auto;
contain-intrinsic-size: 1px 5000px; I have no idea why we have these styles applied. But nevertheless, I'd be fine removing them. |
It also seems that by removing these, the overall style gets broken the width of the content not respecting the window width. That should probably be fixed by using CSS grids. And allocating a fixed width of 250px for the first column and 1fr for the 2nd column. |
There's already a PR open for this: #41869 |
Does the PR addresses both the issues? |
Nope. |
There's an existing issue for this here. Unfortunately there hasn't been any movement on it AFAIK since then. |
Yep, I initially looked through the issues in the wrong repo. |
I'm going to reply on the original issue some thoughts. |
URL:
https://nodejs.org/api/modules.html (or any other api page)
Browser Name:
Chrome
Browser Version:
112.0.5615.139
Operating System:
Windows 10, 21H2, 19044.2846
How to reproduce the issue:
Weird scrolling behaviour (look at the scrollbar):
Modules_.CommonJS.modules._.Node.js.v20.1.0.Documentation.-.Google.Chrome.2023-05-04.10-22-10.-.Trim.mp4
Anchors periodically send to a wrong subsection & reloading the page with an anchor in the url (sometimes) moves the page upwards.
Modules_.CommonJS.modules._.Node.js.v20.1.0.Documentation.-.Google.Chrome.2023-05-04.10-23-11.mp4
The same issue also appears in Edge and in Chrome on Mint on VM.
The text was updated successfully, but these errors were encountered: