If request method is HEAD don't allow writing body bytes.

[ronag]

I've encountered this bug a few times, and it's always confusing and tricky to debug. It would be easier if node did not allow writing bytes to the response body when the request method is HEAD, i.e. throw.

[sumitshinde-84]

// Example Express.js route handler
app.head('/example', (req, res) => {
// Perform some actions
// ...

// If the request method is HEAD, only send headers, not body
if (req.method === 'HEAD') {
// Send response headers
res.setHeader('Content-Type', 'text/plain');
res.setHeader('Custom-Header', 'Custom Value');
res.end();
} else {
// If the request method is not HEAD, send the complete response including body
res.setHeader('Content-Type', 'text/plain');
res.setHeader('Custom-Header', 'Custom Value');
res.end('Response body');
}
});

[sumitshinde-84]

may be this solution will work , i would like to work on this issue

[HinataKah0]

I think the issue is asking to add the check inside Node JS API (not inside the request handler).

The API used to write to the response body is this.
The code can be found in lib/_http_outgoing.js.
Maybe we can explore from that, CMIIW.

[bnoordhuis]

It would be easier if node did not allow writing bytes to the response body

What does this mean? Ignore the data, raise an exception, something else?

It should already be ignoring it (and does, AFAICT.)

[faraz16iqbal]

Can I work on this issue?

[ronag]

What does this mean? Ignore the data, raise an exception, something else?

Raise an exception.

[bnoordhuis]

That's a change that breaks longstanding behavior. I remember when Ryan introduced it, must've been around 2010, 2011.

Should be very carefully tested with citgm and probably not added to v20.x (because LTS.)

[Trott]

may be this solution will work , i would like to work on this issue

Can I work on this issue?

Hi, everyone. If you want to work on it, go for it. But no one gets to claim this issue or have it assigned to them or anything like that. You don't need to ask for permission to work on it. This is to avoid cookie-licking.

[mertcanaltin]

Greetings, I tried to make a solution, do you think it is a good way, I would be very happy if you have comments ❤️

[gerrard00]

I know there's a PR in progress, but I wanted to give it a crack. If nothing else I am now more familiar with the codebase.

My change would also effect responses with the status 204 or 304.

#47732

[marco-ippolito]

I think this was solved with #47732 if not reopen