Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating async_wrap in 0.12.x #4592

Closed
AndreasMadsen opened this issue Jan 8, 2016 · 8 comments
Closed

Updating async_wrap in 0.12.x #4592

AndreasMadsen opened this issue Jan 8, 2016 · 8 comments
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lts Issues and PRs related to Long Term Support releases.

Comments

@AndreasMadsen
Copy link
Member

How likely is it that the async_wrap implementation in 0.12.x will get updated to correspond to that in 5.x.x / master.

AsyncWrap is an undocumented feature and has it own life outside semver. Because of this it is continuously updated in 4.x.x (see: nodejs/Release#59), but what about 0.12.x?

I'm asking because I got an issue about getting my long-stack-trace module to work in 0.12.x, see: AndreasMadsen/trace#20. This will not be possible without the latest features.

@mscdex mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. v0.12 labels Jan 8, 2016
@mscdex
Copy link
Contributor

mscdex commented Jan 8, 2016

/cc @trevnorris

@MylesBorins MylesBorins added lts Issues and PRs related to Long Term Support releases. lts-agenda labels Jan 8, 2016
@MylesBorins
Copy link
Contributor

@AndreasMadsen I'm adding this to the LTS agenda to be discussed.

/cc @jasnell @rvagg

@jasnell
Copy link
Member

jasnell commented Jan 11, 2016

I would say that getting the async_wrap stuff into v0.12 is unlikely at this point. We're currently working on getting the impl in v4 in sync with v5 and master but beyond that getting things sync'd up for v0.12 would be a fairly large change

@trevnorris
Copy link
Contributor

I'm not 100% sure it'd be possible to backport to v0.12. After we've hammered async wrap out before it's "official" I'll be happy to at least take a look at how difficult it would be to backport.

@rvagg
Copy link
Member

rvagg commented Jan 12, 2016

I agree that it's unlikely. We should discuss at an LTS meeting though because I suspect that we'll have agreement that it's not going to happen, saving @trevnorris the effort of looking at it.

@rvagg
Copy link
Member

rvagg commented Jan 12, 2016

Actually .. It's probably worth pulling in @nodejs/tracing to this discussion too so it's not purely an LTS question—there's two issues here: (1) LTS policy and (2) effort, the LTS WG should probably stick to questions of policy and if we can partition it like that then it's up to @nodejs/tracing (well .. @trevnorris effectively) to answer the question of effort.

@AndreasMadsen
Copy link
Member Author

Looks like this was discussed at the LTS WG Meeting 2015-01-11, was there a resolution?

@mhdawson
Copy link
Member

Discussed in latest LTS WG meeting. Async wrap in 0.12.X is far from the latest so the risk is too high so we don't think this should happen, closig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lts Issues and PRs related to Long Term Support releases.
Projects
None yet
Development

No branches or pull requests

8 participants