Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script to update nghttp2 doesn't work #45572

Closed
targos opened this issue Nov 22, 2022 · 3 comments · Fixed by #46698
Closed

Script to update nghttp2 doesn't work #45572

targos opened this issue Nov 22, 2022 · 3 comments · Fixed by #46698
Labels
tools Issues and PRs related to the tools directory.

Comments

@targos
Copy link
Member

targos commented Nov 22, 2022 •
edited
Loading

Running it deletes deps/nghttp2/lib/includes/config.h.

See #45455
@targos targos added the tools Issues and PRs related to the tools directory. label Nov 22, 2022
@krrishdholakia
Copy link

krrishdholakia commented Dec 26, 2022 •
edited
Loading

What version of nghttp2 are you trying to update? - Clerkie

This was referenced Feb 13, 2023
Merged
Merged
@marco-ippolito
Copy link
Member

marco-ippolito commented Feb 16, 2023 •
edited
Loading

#27283 this was the reason why config.h was manually added in the first place.
It is referenced here

node/deps/nghttp2/nghttp2.gyp

Line 15 in a2bbe5f

'HAVE_CONFIG_H',
in the nghttp2.gyp.
Now I'm not sure how do we want to approach the update, we need to change the script and add the instruction on the maintaining-nghttp2 readme to make sure the config.h is not deleted
@RafaelGSS @targos

@targos
Copy link
Member Author

targos commented Feb 17, 2023

If the file should just be kept as-is during updates, we can modify the script to move it temporarily and put it back at the end.

@marco-ippolito marco-ippolito mentioned this issue Feb 17, 2023
Merged
@targos targos linked a pull request Feb 20, 2023 that will close this issue
tools: update-nghttp2 preserve config.h #46698
Merged
nodejs-github-bot pushed a commit that referenced this issue Feb 21, 2023
@marco-ippolito
tools: update-nghttp2 preserve config.h
4737a20 
PR-URL: #46698
Refs: #45572
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this issue Mar 13, 2023
@marco-ippolito @targos
tools: update-nghttp2 preserve config.h
2ff9b20 
PR-URL: #46698
Refs: #45572
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Apr 11, 2023
@marco-ippolito @danielleadams
tools: update-nghttp2 preserve config.h
4da3eec 
PR-URL: #46698
Refs: #45572
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: update-nghttp2 preserve config.h marco-ippolito/node
3 participants
@targos @krrishdholakia @marco-ippolito