Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include OS label to flaky test #43854

Closed
RafaelGSS opened this issue Jul 15, 2022 · 2 comments · Fixed by #44042
Closed

Include OS label to flaky test #43854

RafaelGSS opened this issue Jul 15, 2022 · 2 comments · Fixed by #44042
Labels
meta Issues and PRs related to the general management of the project.

Comments

@RafaelGSS
Copy link
Member

I believe it would be great to include the OS label to issues created as flaky test. It will save time for the person interested in fixing those issues in their OS.

I guess an acceptable approach would be:

  1. Normalize the issue template (use checkbox to select the OS)
  2. Automatically label issues based on step 1 (Not sure if we can adapt the other workflows such as label-pr)

What are your thoughts on this?
@RafaelGSS RafaelGSS mentioned this issue Jul 15, 2022
Merged
@daeyeon daeyeon added the meta Issues and PRs related to the general management of the project. label Jul 17, 2022
@targos
Copy link
Member

targos commented Jul 19, 2022

Do you want to keep this open for 2. ?

@RafaelGSS
Copy link
Member Author

Yes, I'll investigate how I can do that

@RafaelGSS RafaelGSS mentioned this issue Jul 29, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Aug 7, 2022
@RafaelGSS
build: add workflow to label flaky-test platform
ef33e93 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: #44042
Fixes: #43854
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this issue Aug 16, 2022
@RafaelGSS @danielleadams
build: add workflow to label flaky-test platform
5e1ab72 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: #44042
Fixes: #43854
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this issue Aug 23, 2022
@RafaelGSS @ruyadorno
build: add workflow to label flaky-test platform
fecec4d 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: #44042
Fixes: #43854
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this issue Sep 5, 2022
@RafaelGSS @targos
build: add workflow to label flaky-test platform
8de93bc 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: #44042
Fixes: #43854
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
@RafaelGSS @Fyko
build: add workflow to label flaky-test platform
bd1d819 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: nodejs#44042
Fixes: nodejs#43854
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
juanarbol pushed a commit that referenced this issue Oct 10, 2022
@RafaelGSS @juanarbol
build: add workflow to label flaky-test platform
a03ab33 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: #44042
Fixes: #43854
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
juanarbol pushed a commit that referenced this issue Oct 11, 2022
@RafaelGSS @juanarbol
build: add workflow to label flaky-test platform
041bb54 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: #44042
Fixes: #43854
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@RafaelGSS @guangwong
build: add workflow to label flaky-test platform
d3ce9cf 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: nodejs/node#44042
Fixes: nodejs/node#43854
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@RafaelGSS @guangwong
build: add workflow to label flaky-test platform
5dca57c 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: nodejs/node#44042
Fixes: nodejs/node#43854
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: add workflow to label flaky-test platform RafaelGSS/node
3 participants
@targos @daeyeon @RafaelGSS