Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of date node-addon-examples #4339

Closed
jasnell opened this issue Dec 18, 2015 · 8 comments
Closed

Out of date node-addon-examples #4339

jasnell opened this issue Dec 18, 2015 · 8 comments
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@jasnell
Copy link
Member

jasnell commented Dec 18, 2015

See: nodejs/node-addon-examples#46 ...

The Addon examples in the node-addon-examples registry have fallen behind and no longer match the documentation (even tho the documentation says that all of the examples can be downloaded). Updating these could be a good first contribution for someone who wishes to learn more about Addon development.

@jasnell jasnell added good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. mentor-available labels Dec 18, 2015
@rvagg
Copy link
Member

rvagg commented Dec 18, 2015

/cc @nodejs/addon-api

@peteyycz
Copy link
Contributor

I would be more than happy to help, what is it that is missing from the page? I just checked most of the examples with the v0.12 tag are working with v4.2.4

@jasnell
Copy link
Member Author

jasnell commented Dec 30, 2015

@Peteyy ... largely just need someone to go through and make sure that the examples are fully up to date, compile, do not use any deprecated APIs and reflect current best practices.

@peteyycz
Copy link
Contributor

@jasnell I see the mentor-available label on the issue, is there anybody I could contact and what is the preferred medium?

@jasnell
Copy link
Member Author

jasnell commented Dec 30, 2015

Commenting on github is usually best. Just mention either myself or @rvagg and I'm sure we'll be able to get you pointed in the right direction

@italoacasas
Copy link
Contributor

I'm working on the first example

nodejs/node-addon-examples#46

@Trott
Copy link
Member

Trott commented Jun 24, 2016

Can this be closed?

Or am I misunderstanding the issue here?

@rvagg
Copy link
Member

rvagg commented Jun 27, 2016

Blocked by people availability in nodejs/node-addon-examples I think, I just don't have the bandwidth. Would love help from @nodejs/addon-api folks to review existing work there tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Development

No branches or pull requests

5 participants