Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/sequential/test-fs-watch.js hanging on OS X #4082

Closed
evanlucas opened this issue Dec 1, 2015 · 6 comments
Closed

test/sequential/test-fs-watch.js hanging on OS X #4082

evanlucas opened this issue Dec 1, 2015 · 6 comments
Labels
fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.

Comments

@evanlucas
Copy link
Contributor

Possibly related: #1275

It is hanging indefinitely every other run or so

@Trott
Copy link
Member

Trott commented Dec 1, 2015

That's odd. It doesn't hang in CI ever, it seems. A stress test might be interesting to see what that uncovers. What version of OS X are you running? And how are you testing? make test or ./node test/sequential/test-fs-watch.js or what? And you're using something close to master presumably?

@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. macos Issues and PRs related to the macOS platform / OSX. labels Dec 1, 2015
@evanlucas
Copy link
Contributor Author

$ uname -a
Darwin Mac-Pro.local 15.0.0 Darwin Kernel Version 15.0.0: Sat Sep 19 15:53:46 PDT 2015; root:xnu-3247.10.11~1/RELEASE_X86_64 x86_64

OS X 10.11.1

It hangs every other run if run using ./node test/sequential/test-fs-watch.js.

make test hangs 1/4 of the time. (roughly). This is running directly on master as of now

@cjihrig
Copy link
Contributor

cjihrig commented Dec 1, 2015

Hm.. I haven't been able to reproduce with the same machine setup, building master, and running the test ~50 times.

@evanlucas
Copy link
Contributor Author

Here is a small stress test on it https://ci.nodejs.org/job/node-stress-single-test/nodes=osx1010/104/console

I wonder if this is 10.11 specific?

@evanlucas
Copy link
Contributor Author

https://github.com/nodejs/node/blob/master/test/sequential/test-fs-watch.js#L39-L52 is the block that is not being called. The event is not being emit.

@evanlucas
Copy link
Contributor Author

Closing as I am not seeing this issue anymore. I will reopen if it surfaces again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants