Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose async_wrap providers #40730

Closed
RafaelGSS opened this issue Nov 5, 2021 · 2 comments
Closed

Expose async_wrap providers #40730

RafaelGSS opened this issue Nov 5, 2021 · 2 comments
Labels
async_hooks Issues and PRs related to the async hooks subsystem. feature request Issues that request new features to be added to Node.js.

Comments

@RafaelGSS
Copy link
Member

Once process.binding was considered deprecated(v16+), we don't have a public API (AFAIK) to access the process.binding(async_wrap).Providers.

At node-clinic we use it to correlate with stack-traces, is there anything that replaces that information?
@mcollina
Copy link
Member

mcollina commented Nov 5, 2021

I think you can create a new property inside a async_hooks and expose this using a public API.

Could you send a PR?

@Mesteery Mesteery added async_hooks Issues and PRs related to the async hooks subsystem. feature request Issues that request new features to be added to Node.js. labels Nov 5, 2021
@RafaelGSS RafaelGSS mentioned this issue Nov 8, 2021
Merged
@RafaelGSS
Copy link
Member Author

PR created.

Just for reference, I've found #37575 that discuss the same approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @RafaelGSS @Mesteery