Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of consistency in maxRequestPerSocket #40190

Closed
mcollina opened this issue Sep 23, 2021 · 5 comments
Closed

Lack of consistency in maxRequestPerSocket #40190

mcollina opened this issue Sep 23, 2021 · 5 comments
Labels
http Issues or PRs related to the http subsystem.

Comments

@mcollina
Copy link
Member

Version

v16.10.0

Platform

all

Subsystem

http

What steps will reproduce the bug?

server.maxRequestPerSocket as defined in https://nodejs.org/api/http.html#http_server_maxrequestspersocket uses null for "no limit". However in most other places of http we use 0 to identify no limit.

server.maxRequestPerSocket should use 0 as well as null (to not break anybody), or just consider it a bugfix and remove null support.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response
@mcollina mcollina added the http Issues or PRs related to the http subsystem. label Sep 23, 2021
@mcollina
Copy link
Member Author

cc @ronag

@mcollina
Copy link
Member Author

This was added in #40082

wdyt @fatal10110, would you be able to send a fix?

@mcollina mcollina mentioned this issue Sep 23, 2021
Merged
4 tasks
@fatal10110
Copy link
Contributor

Sure

@fatal10110 fatal10110 mentioned this issue Sep 23, 2021
Closed
@fatal10110
Copy link
Contributor

Since #40192 landed, I guess we can close it?

@mcollina
Copy link
Member Author

yes, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http: use 0 as default for requests limit fatal10110/node
2 participants
@mcollina @fatal10110