"fs.fdatasyncSync" results in an abort

[zyscoder]

• Version: v10.24.0
• Platform: Linux 5.8.0-38-generic The binary and long term compatibility with node #43~20.04.1-Ubuntu SMP Tue Jan 12 16:39:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: fs.fdatasyncSync

What steps will reproduce the bug?

Setup a node instance,

» node

and run the following javascript code.

fs.fdatasyncSync(2147483648)

Then an abort occurs.

How often does it reproduce? Is there a required condition?

This problem can always be triggered following the steps above.

What is the expected behavior?

If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.

What do you see instead?

» node
> fs.fdatasyncSync(2147483648)
/home/zys/Toolchains/node-v10.24.0/node[294234]: ../src/node_file.cc:1177:void node::fs::Fdatasync(const FunctionCallbackInfo<v8::Value> &): Assertion `args[0]->IsInt32()' failed.
 1: 0x17c3524 node::DumpBacktrace(_IO_FILE*) [/home/zys/Toolchains/node-v10.24.0/node]
 2: 0x1818dbe node::Abort() [/home/zys/Toolchains/node-v10.24.0/node]
 3: 0x1816245  [/home/zys/Toolchains/node-v10.24.0/node]
 4: 0x18a8540  [/home/zys/Toolchains/node-v10.24.0/node]
 5: 0x1ec8fe9 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) [/home/zys/Toolchains/node-v10.24.0/node]
 6: 0x1ec67fa  [/home/zys/Toolchains/node-v10.24.0/node]
 7: 0x1ec4538  [/home/zys/Toolchains/node-v10.24.0/node]
 8: 0x7eee449dbf3d 
[2]    294234 abort (core dumped)  node

Additional information

[Linkgoron]

This was fixed in Node 12 here, I believe: #28984

[aduh95]

I guess one could open a backport PR to have the fix land in v10.x, but it's unlikely to happen as v10.x in EOL in about a month.

[targos]

@zyscoder we appreciate you opening these issues, but they are not going to be fixed for Node.js v10.x. That release line is in Maintenance and can only get critical bug fixes and security patches.