-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process 'error' event is undocumented #36770
Comments
I wonder if we want to keep it or emit uncaughtException directly since no-one actually complained about this or asked for this since EventEmitter was added. We can also just doc it. |
Any strong opinions? |
I was definitely caught by surprise by this being added, and would be happy to treat it as uncaught exceptions (i.e. act as if there’s no |
What's the issue here? There is documentation for this: https://nodejs.org/dist/latest-v15.x/docs/api/events.html#events_eventtarget_error_handling |
https://nodejs.org/api/process.html#process_process_events is missing them – we always document events on the emitter. |
@jasnell any strong opinions about making this an |
About making what an |
@jasnell About making an exception inside a |
I'll try taking a stab at this |
Change the behavior of EventTarget, instead of emitting 'error' on handler exception, emit 'uncaughtException'. Fixes: nodejs#36770
Change the behavior of EventTarget, instead of emitting 'error' on handler exception, emit 'uncaughtException'. Fixes: nodejs#36770
Change the behavior of EventTarget, instead of emitting 'error' on handler exception, emit 'uncaughtException'. Fixes: nodejs#36770
Change the behavior of EventTarget, instead of emitting 'error' on handler exception, emit 'uncaughtException'. Fixes: nodejs#36770
Change the behavior of EventTarget, instead of emitting 'error' on handler exception, emit 'uncaughtException'. Fixes: nodejs#36770
Change the behavior of EventTarget, instead of emitting 'error' on handler exception, emit 'uncaughtException'. Fixes: nodejs#36770
node/lib/internal/event_target.js
Line 604 in 8b8620d
The text was updated successfully, but these errors were encountered: