Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FATAL ERROR: v8::HandleScope::CreateHandle() #3598

Closed
S-YOU opened this issue Oct 30, 2015 · 5 comments
Closed

FATAL ERROR: v8::HandleScope::CreateHandle() #3598

S-YOU opened this issue Oct 30, 2015 · 5 comments

Comments

@S-YOU
Copy link

S-YOU commented Oct 30, 2015

I am using prerenderjs and getting following error with node 5.0.0

FATAL ERROR: v8::HandleScope::CreateHandle() Cannot create a handle without a HandleScope

May be it is not nodejs issue, but prerender or phantom/phantomjs or node-weak issue, but anyone have any clue how to work around this?

@S-YOU
Copy link
Author

S-YOU commented Oct 30, 2015

Figured it. It was weak issue.

@S-YOU S-YOU closed this as completed Oct 30, 2015
@Smbc1
Copy link

Smbc1 commented Nov 5, 2015

@S-YOU, need more info, could you please describe issue in weak module?

@S-YOU
Copy link
Author

S-YOU commented Nov 6, 2015

@Unterdrucker, I fixed it in my branch by moving Nan::HandleScope scope; outside NAN_MODULE_INIT in src/weakref.cc

TooTallNate/node-weak@master...S-YOU:node5

It fixed the error, but I am not definitely sure it is correct way, so, I am not sending PR.

@Smbc1
Copy link

Smbc1 commented Nov 6, 2015

@S-YOU, thank you, it works in release. I think, you should send PR. It's definitely fixes issue, however, I don't know would it affect any other way or not. I think, maintainers of node-weak should know, accept PR or not.

@S-YOU
Copy link
Author

S-YOU commented Nov 6, 2015

Ok, I have sent PR there - TooTallNate/node-weak#66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants